Skip to content

Add bcd key insert, retreival, tests #1469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

suprith-hub
Copy link
Contributor

@suprith-hub suprith-hub commented May 6, 2025

Adds feature search by BCD key.
Addresssing the issue
Majorly:

  1. Use and store CompatFeatures from web-platform-dx
  2. Create a table to store compat features
  3. Query and function to retrieve from table
  4. Modify search grammar to support bcd key

@suprith-hub suprith-hub changed the title Add bcd insert, retreival, tests Add bcd key insert, retreival, tests May 6, 2025
@suprith-hub suprith-hub marked this pull request as ready for review May 7, 2025 19:14
@suprith-hub
Copy link
Contributor Author

@jcscottiii I’ve completed all the changes, and run successful precommit.
It was interesting and my first backend contribution.

During development, I needed to inspect database data, so I used:

kubectl port-forward pod/spanner 9010:9010 9020:9020
spanner-cli -p local -i local -d local --endpoint=localhost:9010

This allowed me to run queries directly against the local Spanner emulator.

We might want to document this workflow for others — including how to debug Go services inside devcontainers — as it makes local development and debugging much smoother.

Let me know what you think!

@suprith-hub
Copy link
Contributor Author

Also @jcscottiii
Screenshot from 2025-05-08 20-26-19
Should the search by description be disallowed ?

@suprith-hub
Copy link
Contributor Author

@jcscottiii can you review this PR.
Can I continue contributing on more issues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants