Move saved-search-editor up to parent component #1487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for tackling this. One thing to note:
If the interaction happens in a sub component and needs to let an ancestor component know, it should raise an event. [1] |
I see - I'll update the implementation to use this paradigm. 🙂 |
jcscottiii
reviewed
May 14, 2025
frontend/src/static/js/components/webstatus-overview-content.ts
Outdated
Show resolved
Hide resolved
jcscottiii
reviewed
May 14, 2025
frontend/src/static/js/components/webstatus-overview-content.ts
Outdated
Show resolved
Hide resolved
jcscottiii
approved these changes
May 16, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes some known stacking issues which caused some elements to render above the saved search dialog. The webstatus-saved-search-editor component now lives in the webstatus-overview-content component, which alleviates stacking issues.
A new event,
open-saved-search-editor, is dispatched in webstatus-saved-search-controls, and handled in webstatus-overview-content, to trigger the open action of the saved search dialog.All tests have been moved and adjusted, the the overall number not being changed.