refactor(gcpspanner): Generalize Spanner helpers for pointers and pagination #1986
+285
−119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Split up of #1985 |
…ination
This foundational commit refactors the generic Spanner entity helpers to improve consistency, reduce boilerplate, and support more advanced use cases like cursor-based pagination. This makes the data access layer more robust and maintainable for the features that will be added subsequently.
- `client.go`:
- The generic `entityCreator`'s `create` and `createWithTransaction` methods now return `*string` for the newly created entity's ID.
- The generic `entityLister` has been refactored to use an interface-driven approach for pagination, returning a `*string` for the next page token.
- The generic `entityRemover` has been updated to be key-based, simplifying its usage.
- Existing Callers Updated:
- Updated all existing callers of these generic helpers throughout the `lib/gcpspanner/` package to align with the new function signatures and patterns.
jcscottiii
force-pushed
the
feat/1-refactor-helpers
branch
from
4389ae8 to
ac96792
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This foundational commit refactors the generic Spanner entity helpers to improve consistency, reduce boilerplate, and support more advanced use cases like cursor-based pagination. This makes the data access layer more robust and maintainable for the features that will be added subsequently.
client.go:entityCreator'screateandcreateWithTransactionmethods now return*stringfor the newly created entity's ID.entityListerhas been refactored to use an interface-driven approach for pagination, returning a*stringfor the next page token.entityRemoverhas been updated to be key-based, simplifying its usage.lib/gcpspanner/package to align with the new function signatures and patterns.