-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide backdrop for popover #624
Conversation
oh yes, good call, visbug popovers will inherit any backdrop styles. we def don't want that! thanks for the site where we can test 👍🏻 curious your thoughts here: I verified the bug is fixed with the following styles. What i like about this is that it's not changing the host page, it's changing visbug. vis-bug::backdrop,
visbug-handles::backdrop,
visbug-hover::backdrop,
visbug-distance::backdrop {
background: none;
} if we like this route better, i believe we just add the following to each elements shadow root that is a popover. ::backdrop {
background: none;
} the PR would touch more files (like this one) but i think the solution is less leaky or side effecty? thoughts? do you think it would surprise someone if they launched visbug and all their backdrops disappeared? |
Sounds good let me push an update! |
I think this should be all the popover. Seems to work in test for me. |
since the CI no longer auto deploys the extension, and by the looks of this PR test run more is broken.. I'll need to do it Monday next week or so.. but thanks for this! looks great 🎉 |
just uploaded a new build, sorry it took so long! I have excused, but listing them wouldn't make anything better. |
No worries, thanks for the maintenance! |
Certain sites might color their popover backdrop, overriding to keep it visible.
https://ng-matero.github.io/ng-matero