Baseline checker updates - #42
Conversation
…in-deploy Deploy baseline-checker to subdomain
| "scripts": { | ||
| "start": "http-server public -c -1 -p 3000", | ||
| "deploy": "gcloud storage rsync --recursive --delete-unmatched-destination-objects public gs://chrome-dev-demos/public/google-analytics-baseline-checker" | ||
| "deploy": "gcloud storage rsync --recursive --delete-unmatched-destination-objects public gs://chrome-dev-demos/subdomains/baseline-checker" |
There was a problem hiding this comment.
If we're changing the URL to a subdomain, we need to also set up a redirect from the existing URL.
There was a problem hiding this comment.
Yes @devnook said she would set that up after the verification was approved, so I assume that'll be done tomorrow
I've updated the URL in Paul's slide to point to the subdomain and pinged Jeremy about it so he can update the docs
There was a problem hiding this comment.
Update: we're going to hold off on the redirect and have both apps up at the same time to give users a fallback option if they have a Workspace account and are unable to use this one
| return; | ||
| } | ||
|
|
||
| fetchReportData(propertyId, days); |
There was a problem hiding this comment.
Nit: when I click on this button, it takes a few seconds to fetch and process the data, but I don't get any immediate feedback that anything is happening.
It would be nice if the button switched to the disabled state while fetching and then switched back once the report was ready. You could even update the text to say something like "Loading..."
There was a problem hiding this comment.
I went with aria-disabled with "Loading..." text, for consistency with MWG 😁
|
Looks great! |
|
Moving back to draft mode to prevent accidentally merging into main. We should hold off on merging until we're ready to get rid of the legacy app. Meanwhile I've deployed this to the separate subdomain so both versions will be available. |
|
@devnook now that the workspace issue is resolved, I think we're ready to merge this and set up the permanent redirect from https://chrome.dev/google-analytics-baseline-checker/ to https://baseline-checker.chrome.dev/ |
3 participants
https://baseline-checker.chrome.dev/