feat: emulate geolocation positionUnavailable#3359
Merged
sadym-chromium merged 5 commits intomainfrom Apr 30, 2025
Merged
Conversation
sadym-chromium
changed the title
Lightning00Blade
approved these changes
Apr 30, 2025
Collaborator
Lightning00Blade
left a comment
Lightning00Blade
left a comment
There was a problem hiding this comment.
LGTM, with one nit - we can even drop the Override suffix, as everything on the config is technically and override.
browser-automation-bot
added a commit
to browser-automation-bot/chromium-bidi
that referenced
this pull request
Apr 30, 2025
sadym-chromium
force-pushed
the
sadym/geolocation-position-unavailable
branch
from
0e1907f to
0d328f8
Compare
OrKoN
approved these changes
Apr 30, 2025
sadym-chromium
pushed a commit
that referenced
this pull request
May 2, 2025
🤖 I have created a release *beep* *boop* --- ## [4.2.0](chromium-bidi-v4.1.1...chromium-bidi-v4.2.0) (2025-04-30) ### Features * emulate geolocation positionUnavailable ([#3359](#3359)) ([6975bcc](6975bcc)) * provide proper context id in `browsingContext.userPrompt` ([#3349](#3349)) ([e504ba1](e504ba1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec is landed in w3c/webdriver-bidi#911