Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfixes #104

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Bugfixes #104

merged 2 commits into from
Jul 30, 2024

Conversation

ycheng627
Copy link
Collaborator

No description provided.

ycheng627 added 2 commits July 30, 2024 14:20
@ycheng627
[Bugfix] fix typo
52bb567 
Fix typo from `paylaod` to `payload`.
@ycheng627
[Bugfix] Improve UX by showing output once event stops capturing
c88f110 
We should show the events that are captured even after we stop
capturing event for better UX.
@ycheng627 ycheng627 requested a review from BaiiYuan July 30, 2024 06:24
BaiiYuan
BaiiYuan approved these changes Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@BaiiYuan BaiiYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ycheng627 ycheng627 merged commit b9d3cf4 into main Jul 30, 2024
5 checks passed
@ycheng627 ycheng627 deleted the bugfixes branch July 30, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BaiiYuan BaiiYuan BaiiYuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ycheng627 @BaiiYuan