Skip to content

Conversation

@fastpok
Copy link
Contributor

@fastpok fastpok commented Feb 28, 2025

Related to #93

@google-cla
Copy link

google-cla bot commented Feb 28, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@fastpok
Copy link
Contributor Author

fastpok commented Feb 28, 2025

I haven't been able to sign the СLA yet. Something is not working.

image

@tomayac
Copy link
Member

tomayac commented Feb 28, 2025

Thanks for this! Could you add a demo for this as well? And maybe add it as version 3 in the README (mentioning that it doesn't profit form the load optimization that <link> has)?

@fastpok
Copy link
Contributor Author

fastpok commented Mar 3, 2025

Yes, no problem.

@fastpok
Copy link
Contributor Author

fastpok commented May 5, 2025

I'm sorry for the long pause. I added a demo and I managed to sign the CLA.

Copy link
Member

@tomayac tomayac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@tomayac tomayac merged commit 4ea28a4 into GoogleChromeLabs:main May 7, 2025
2 checks passed
@tomayac
Copy link
Member

tomayac commented May 7, 2025

Released as v0.17.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants