Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Playwright Test Suite: realtime-sine (MVP) #372

Merged
merged 60 commits into from
Jul 17, 2024
Merged

Playwright Test Suite: realtime-sine (MVP) #372

merged 60 commits into from
Jul 17, 2024

Conversation

terryzfeng
Copy link
Collaborator

@terryzfeng terryzfeng commented Jul 10, 2024 •
edited by hoch
Loading

This PR Implements the "realtime-sine" test with basic infrastructure/framework.

Instruction for local testing

  • npm install
  • npx playwright install
  • Then npm run test or npm run test-live
    • npm run test for Playwright tests.
    • npm run test-live for live suite; after the comment, open up a browser and go to localhost:8080.

The test result looks like this for npm run test:
Screenshot 2024-07-15 at 8 41 09 AM

The test result looks like this for npm run test-live:
Screenshot 2024-07-15 at 8 44 37 AM

terryzfeng and others added 30 commits May 30, 2024 16:54
@terryzfeng
initialize playwright framework with basic hello sine tests
8c92bbc
@terryzfeng
port over AW addmodule resolution test
7c38538
@terryzfeng
prepare Playwright test framework
d6696b5
@terryzfeng
update playwright CI to only test on chromium
b87790a
@terryzfeng
remove realtime test start button
dc5a278
@Kizjkre
Tentative integration of audio worklet recorder
8f4404d
@Kizjkre
Reduce file count per test
c5a7eef
@terryzfeng
compared MVP realtime audioContext to reference float32Array
86f9e7e
@Kizjkre
Fix lint errors
82fe7f6
@Kizjkre
Remove unused import
ba87acd
@terryzfeng
refactored test files and attempted python child process
d029f50
@terryzfeng
fix merge
fdb4415
@Kizjkre
Merge remote-tracking branch 'origin/playwright-test' into playwright…
7665bbf 
…-test

# Conflicts:
#	src/tests/playwright/pages/realtime-sine.html
@Kizjkre
Python subproceas doesn't work
436bf6c
@Kizjkre
Tentative integration of live test suite in web-audio-sampels
b9b13ba
@terryzfeng
refactor playwright tests for live-suite
9bf7de0
@terryzfeng
@Kizjkre partially integrate live test suite
2cb6ed3
@Kizjkre @terryzfeng
Create bufferinator and audio graph cache
0c41e3c 
Co-authored-by: terryzfeng <[email protected]>
@Kizjkre
Change default exports to named exports
4ddc7e9
@terryzfeng
bump playwright version
0c9e322
@terryzfeng @Kizjkre
implement library functions for dsp graph building and realtime and o…
055cd61 
…ffline audio buffer comparison

Co-authored-by: kizjkre <[email protected]>
@terryzfeng
feat: add playwright multiple chromium version support
6ee4009 
feat: add beCloseTo impl

feat: impl buffer comparison and graph evaluation

refactor: realtimeSine test, recorder-main, etc.

test: add dsp graph eval test
@terryzfeng
style: fix ending newlines
32d2de3 
remove: unnecessary run.py
@terryzfeng
regenerate reference sine from offline context AND same computer
07f9d48 
Co-authord-by: Kizjkre <[email protected]>
@terryzfeng @Kizjkre
regenerate reference sine from offline context AND same computer
8bfa140 
Co-authored-by: Kizjkre <[email protected]>
@Kizjkre
Merge remote-tracking branch 'origin/playwright-test' into playwright…
ed1a633 
…-test
@Kizjkre @terryzfeng
Connect tests to live suite
c28ee78 
Co-authored-by: terryzfeng <[email protected]>
@Kizjkre @terryzfeng
Fix bug where DSP graph evaluation could only be run once
21cbcac 
Co-authored-by: terryzfeng <[email protected]>
@Kizjkre
Integrate evaluation function into live suite
5811046
@terryzfeng
refactor realtime-sine test as test example
126c6f1
@Kizjkre Kizjkre added the gsoc24 Google Summer of Code 2024 label Jul 10, 2024
@terryzfeng
Copy link
Collaborator Author

We will cut down the tests to only realtime-sine for this MVP, aiming to do this by Thursday

@hoch
Copy link
Member

hoch commented Jul 10, 2024

Thanks for the updates and clear communication!

@hoch hoch changed the title Playwright MVP Playwright Test Suite: realtime-sine (MVP) Jul 11, 2024
@Kizjkre Kizjkre requested review from hoch and mjwilson-google July 11, 2024 23:07
hoch
hoch requested changes Jul 12, 2024
View reviewed changes
Copy link
Member

@hoch hoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

My comments are mostly for style and naming. It should be trivial to address them.

A few general suggestions on some important terms:

  1. buffer - AudioBuffer, float32array - ChannelData
  2. length - discrete size (e.g. buffer size, sample count), duration - time (e.g. seconds)

I think this principal generally works consistently in this repo and Chromium WebAudio WPTs. Of course we can have a discussion on this topic because the most of convention is something I created over time.

hoch
hoch requested changes Jul 13, 2024
View reviewed changes
Copy link
Member

@hoch hoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My focus is to make the future maintenance easier by clarifying names and adding comments. We are very close to landing this - thanks for your patience!

@terryzfeng terryzfeng linked an issue Jul 16, 2024 that may be closed by this pull request
Research various JS testing frameworks #365
Closed
@terryzfeng @Kizjkre
fix all PR reviews
8aaf01d 
Co-authored-by: Kizjkre <[email protected]>
@Kizjkre Kizjkre requested a review from hoch July 16, 2024 22:30
hoch
hoch approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@hoch hoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nit - you don't need another review. Just fix the nit and merge the PR.

Thanks for being patient and I am happy to see the team work in this PR! :)

Kizjkre and others added 2 commits July 16, 2024 15:57
Kizjkre
Kizjkre approved these changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@Kizjkre Kizjkre left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed! @hoch, can you merge if you see fit?

@hoch hoch merged commit 2d19312 into main Jul 17, 2024
5 checks passed
@hoch
Copy link
Member

hoch commented Jul 17, 2024

Done! Thanks for working on this @Kizjkre and @terryzfeng! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoch hoch hoch approved these changes

@Kizjkre Kizjkre Kizjkre approved these changes

@mjwilson-google mjwilson-google Awaiting requested review from mjwilson-google

Assignees

@Kizjkre Kizjkre

@terryzfeng terryzfeng

Labels
gsoc24 Google Summer of Code 2024
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Research various JS testing frameworks
3 participants
@terryzfeng @hoch @Kizjkre