Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade eslint to be compatible with eslintrc #373

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Downgrade eslint to be compatible with eslintrc #373

merged 1 commit into from
Jul 10, 2024

Conversation

Kizjkre
Copy link
Collaborator

@Kizjkre Kizjkre commented Jul 10, 2024

Downgrade eslint from 9.5.0 to 8.57.0 to be compatible with eslintrc.

@Kizjkre Kizjkre self-assigned this Jul 10, 2024
@Kizjkre Kizjkre requested review from hoch and mjwilson-google July 10, 2024 01:09
@Kizjkre Kizjkre added the gsoc24 Google Summer of Code 2024 label Jul 10, 2024
@hoch
Copy link
Member

hoch commented Jul 10, 2024

I found this, but couldn't find any reference that points the version 8.57.0. How did you find it out? :)

hoch
hoch approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@hoch hoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kizjkre
Copy link
Collaborator Author

Kizjkre commented Jul 10, 2024

It seems like ESLint >=9 uses an eslint.config.js file (with a different syntax) rather than a .eslintrc.json file. Since we use .eslintrc.json, I thought to downgrade to the last stable version of ESLint 8 to maintain compatability.

@hoch hoch merged commit 85ec064 into main Jul 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoch hoch hoch approved these changes

@mjwilson-google mjwilson-google Awaiting requested review from mjwilson-google

Assignees

@Kizjkre Kizjkre

Labels
gsoc24 Google Summer of Code 2024
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kizjkre @hoch