Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FreeQueueSAB: automated test coverage #374

Merged
merged 15 commits into from
Jul 30, 2024
Merged

FreeQueueSAB: automated test coverage #374

merged 15 commits into from
Jul 30, 2024

Conversation

abhayporwals
Copy link
Collaborator

@abhayporwals abhayporwals commented Jul 10, 2024

  • Installed needed package - Mocha and Chai ✅
  • Folder Structure Setup ✅
  • Test cases for FreeQueueSAB Class ✅

Fixes #347

@abhayporwals abhayporwals added the gsoc24 Google Summer of Code 2024 label Jul 10, 2024
@abhayporwals abhayporwals self-assigned this Jul 10, 2024
@hoch hoch changed the title Comprehensive Test Coverage FreeQueue: automated test coverage Jul 11, 2024
@hoch
Copy link
Member

hoch commented Jul 11, 2024

The PR at the moment only adds two packages. Perhaps it's not ready for the review yet? :)

@abhayporwals
Copy link
Collaborator Author

The PR at the moment only adds two packages. Perhaps it's not ready for the review yet? :)

Hey, @hoch! Hope you are doing well.
Yes, it's not ready for the review yet.
I have a last exam today. After that I'll be free from tomorrow and push the code soon. I have created the Test Cases for the FreeQueueSAB class.

Copy link
Member

@hoch hoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks generally good, but I assume this is the first PR of many. Right?

@abhayporwals
Copy link
Collaborator Author

Looks generally good, but I assume this is the first PR of many. Right?

As per the discussion in the last meeting, we will cover all the test cases related to the FreeQueueSAB class in this PR and create a new PR for all test cases related to the FreeQueue class.

I'll be committing more test cases related to performance testing soon. Please provide me a review and any case that is not covered according to you so that we can move towards finalizing this PR.

Copy link
Collaborator

@mjwilson-google mjwilson-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting some errors when trying to run the tests. Please take a look.

Is it possible to include the necessary mocha and chai support files locally, or implement the parts we need separately?

Also we may need to include the following line in .eleventy.js to include the test html file in the project:
'src/lib/**/*.html',

@abhayporwals
Copy link
Collaborator Author

@mjwilson-google
Copy link
Collaborator

I'm seeing the same failure in the "should fail to push data when buffer is full" test. I'll take a look too.

@abhayporwals
Copy link
Collaborator Author

I'm seeing the same failure in the "should fail to push data when buffer is full" test. I'll take a look too.

I figured it out. I'll push the update tomorrow.

@abhayporwals abhayporwals changed the title FreeQueue: automated test coverage FreeQueueSAB: automated test coverage Jul 23, 2024
Copy link
Collaborator

@mjwilson-google mjwilson-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. If you agree with my other comments please make the changes and we can merge this.

I noticed that there is still the console error about the unexpected export token in chai.js, but it doesn't seem to cause any problems so I don't think we need to worry about it.

@abhayporwals
Copy link
Collaborator Author

abhayporwals commented Jul 30, 2024

We are good to merge this PR now.
That error on the console is coming because of the webpack bundler but it's not impacting anything in our tests.
I'll try to find a way to resolve this and if got something then update it in the new PR.

@mjwilson-google mjwilson-google merged commit a37e812 into main Jul 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gsoc24 Google Summer of Code 2024
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve RingBuffer
3 participants