Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web Audio Test Suite Documentation #381

Merged
merged 4 commits into from
Jul 24, 2024
Merged

Web Audio Test Suite Documentation #381

merged 4 commits into from
Jul 24, 2024

Conversation

Kizjkre
Copy link
Collaborator

@Kizjkre Kizjkre commented Jul 17, 2024 •
edited by terryzfeng
Loading

Includes:

  • How to write tests for Playwright and Live Suite running
  • Sample template.html for test writing
  • Notes for Playwright Configuration and Browser setup
  • API documentation of audit.js and recorder object.

@terryzfeng @Kizjkre
Start working on docs
2b5d03d 
Co-authored-by: Kizjkre <[email protected]>
@Kizjkre Kizjkre added the gsoc24 Google Summer of Code 2024 label Jul 17, 2024
@Kizjkre Kizjkre requested a review from terryzfeng July 17, 2024 00:12
@terryzfeng terryzfeng changed the title Add documentation and port performance tests from WPT to Playwright and Live Suite tests Web Audio Test Suite Documentation Jul 17, 2024
terryzfeng
terryzfeng approved these changes Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@terryzfeng terryzfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some playwright information to the README and improved the first draft.

@terryzfeng
Copy link
Collaborator

I think that this is a good starting point for Web Audio Test Documentation! Would appreciate your feedback on the README guide! @hoch @mjwilson-google

hoch
hoch approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@hoch hoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nice documentation work! LGTM

@Kizjkre
Copy link
Collaborator Author

Kizjkre commented Jul 24, 2024

@hoch @mjwilson-google would it be possible to merge this if it looks good?

@hoch hoch merged commit 6aa93ad into main Jul 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoch hoch hoch approved these changes

@terryzfeng terryzfeng terryzfeng approved these changes

@mjwilson-google mjwilson-google Awaiting requested review from mjwilson-google

Assignees

@Kizjkre Kizjkre

@terryzfeng terryzfeng

Labels
gsoc24 Google Summer of Code 2024
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kizjkre @terryzfeng @hoch