-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playwright Port Performance Tests #384
Conversation
Co-authored-by: Kizjkre <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks great! Hope we can tidy this further.
Co-authored-by: Kizjkre <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some directional comments:
- If the comment explains "what's being done", probably it's better to revise the code so it is more readable and remove the comment.
- Anything empirical/arbitrary (e.g. accuracy number) should have a comment on why. If it's unclear, we can always "this is arbitrary".
- Assume that someone else will touch the code later. The code that is easier to read is better than the code being cryptic and clever!
- Try to avoid general variable names (e.g. bufferData, float32buffer).
Thanks for your patience, and I think we are almost there!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nits
Co-authored-by: terryzfeng <[email protected]>
Co-authored-by: terryzfeng <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Let's get this out!
Thanks for your patience, @terryzfeng and @Kizjkre! |
Porting Performance Tests from https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/perf_tests/webaudio/
to Web Audio Test Suite