-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #362 - Implemented PR352: One-Pole Filter Audio Worklet, Updated Noise-Generator, Volume-Meter, and Audio-Worklet-Node-Options #390
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for your contribution!
Hi @hoch All 4 examples are now completed. It's now ready to merge. |
We discussed having separate pull requests for each example rather than completing all four in a single PR. |
So, shall I create separate PRs for each task? |
Thanks for sharing your thoughts, @duojet2ez! I think the scope of this PR is adequate - now we found a common pattern that works reasonably well for all examples, so the review was also fast. |
There's a check failing and I'll have to take a look at what's going on. |
@tarunsinghofficial Could you please update the title of PR to reflect the increased scope? |
Sure. Updated the title of the PR. Let me know if it's correct. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a nit. Could you fix them before we merge this?
Fixes #362 implemented the PR352 - one-pole-filter audio worklet sample.