Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .nojekyll file, resolves #402 #403

Closed
wants to merge 1 commit into from
Closed

Add .nojekyll file, resolves #402 #403

wants to merge 1 commit into from

Conversation

Kizjkre
Copy link
Collaborator

@Kizjkre Kizjkre commented Oct 1, 2024

No description provided.

@Kizjkre Kizjkre added the gsoc24 Google Summer of Code 2024 label Oct 1, 2024
@Kizjkre Kizjkre self-assigned this Oct 1, 2024
mjwilson-google
mjwilson-google reviewed Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@mjwilson-google mjwilson-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it also be possible to fix this by renaming the _app directory to something that doesn't start with an underscore?

@Kizjkre
Copy link
Collaborator Author

Kizjkre commented Oct 1, 2024

I could try, but it would be more difficult since the _app directory is built by the Svelte build process.

mjwilson-google
mjwilson-google approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@mjwilson-google mjwilson-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thanks!

@terryzfeng
Copy link
Collaborator

terryzfeng commented Oct 1, 2024 •
edited
Loading

Would it also be possible to fix this by renaming the _app directory to something that doesn't start with an underscore?

I renamed _app to app in the Svelte build config. Thanks for the suggestion @mjwilson-google !

@terryzfeng terryzfeng closed this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjwilson-google mjwilson-google mjwilson-google approved these changes

@hoch hoch Awaiting requested review from hoch

Assignees

@Kizjkre Kizjkre

Labels
gsoc24 Google Summer of Code 2024
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kizjkre @terryzfeng @mjwilson-google