Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update benchmark-web-vitals to allow connection to existing browser instance (e.g. on mobile device) #58

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
+27 −5
Draft

Update benchmark-web-vitals to allow connection to existing browser instance (e.g. on mobile device) #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
daa19e2
Add -c/--connect option to connect to existing browserWSEndpoint
westonruter Jul 21, 2023
05fe15a
Print error message and error object separately
westonruter Jul 21, 2023
2fc78fe
Install wp-prettier for compat with @wordpress/prettier-config
westonruter Jul 21, 2023
c0435c6
Fix prettier issue
westonruter Jul 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion cli/commands/benchmark-web-vitals.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,20 @@ export const options = [
description:
'Whether to show more granular percentiles instead of only the median',
},
{
argname: '-c, --connect <browserWSEndpoint>',
description: 'Connect to an existing browser instance',
},
];

async function getBrowser( opt ) {
return opt.connect
? puppeteer.connect( {
browserWSEndpoint: opt.connect,
} )
: puppeteer.launch();
}

export async function handler( opt ) {
if ( ! isValidTableFormat( opt.output ) ) {
log(
Expand All @@ -78,7 +90,7 @@ export async function handler( opt ) {
const { number: amount } = opt;
const results = [];

const browser = await puppeteer.launch();
const browser = await getBrowser( opt );

for await ( const url of getURLs( opt ) ) {
const { completeRequests, metrics } = await benchmarkURL( browser, {
Expand Down
3 changes: 2 additions & 1 deletion cli/run.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,8 @@ const catchException = ( handler ) => {
try {
await handler( ...args );
} catch ( error ) {
log( formats.error( error ) );
log( formats.error( `Error: ${ error.message }` ) );
console.error( error ); // eslint-disable-line no-console
process.exitCode = 1;
}
};
Expand Down
14 changes: 11 additions & 3 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
"csv-stringify": "^6.2.0",
"lodash-es": "4.17.21",
"node-fetch": "^3.3.0",
"prettier": "npm:[email protected]",
"puppeteer": "^19",
"table": "^6.8.0"
},
Expand Down