feature/ Catalog implementation - Updated folder structure and added Catalog to activity bar#350
Conversation
…-accenture/dataproc-jupyter-plugin-fork" This reverts commit bcea304, reversing changes made to da15ffc.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request rebrands the "Dataset Explorer" functionality as "Catalog" to better represent its expanded capabilities. The change allows the panel to display a broader range of data assets, including BigQuery and BigLake, enhancing its utility as a central data discovery tool. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request renames the 'Dataset Explorer' to 'Catalog' for the BigQuery panel, which is a clear improvement given the expanded scope. The changes are mostly straightforward string and variable replacements. I've suggested a few minor changes to improve consistency in variable and test naming. Also, consider renaming the test file ui-tests/tests/bigquery_dataset_explorer.spec.ts to something like ui-tests/tests/catalog.spec.ts to reflect the feature's new name.
624d21f to
e819137
Compare
Catalog Implementation: This feature is to expand the Dataset Explorer panel's scope from displaying only native BigQuery assets to include both BigQuery and BigLake assets.
Changes included in the CL: