Skip to content

test: update libraries-bom to 26.74.0-rc1#1582

Draft
mpeddada1 wants to merge 3 commits intoGoogleCloudDataproc:masterfrom
mpeddada1:update-bom
Draft

test: update libraries-bom to 26.74.0-rc1#1582
mpeddada1 wants to merge 3 commits intoGoogleCloudDataproc:masterfrom
mpeddada1:update-bom

Conversation

@mpeddada1
Copy link

@mpeddada1 mpeddada1 commented Dec 4, 2025

Running mvn -pl gcsio install is successful with the latest bom version

@gemini-code-assist
Copy link

Summary of Changes

Hello @mpeddada1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to standardize and update the project's Google Cloud library dependencies by explicitly setting the libraries-bom version to 26.72.0. This change ensures that all Google Cloud libraries used within the project are aligned with this specific Bill of Materials version, providing consistency and potentially incorporating the latest features and fixes.

Highlights

  • Dependency Update: The libraries-bom dependency version has been updated from a placeholder variable to a fixed version 26.72.0.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the libraries-bom version. However, instead of updating the google.cloud.library.bom.version property, the version has been hardcoded. This deviates from the practice of managing versions via properties, which is established in this pom.xml and is crucial for maintainability. My review comment suggests reverting this change and updating the property value instead.

pom.xml Outdated
<groupId>com.google.cloud</groupId>
<artifactId>libraries-bom</artifactId>
<version>${google.cloud.library.bom.version}</version>
<version>26.72.0</version>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Hardcoding the version number here makes it inconsistent with the rest of the project's dependency management, which uses properties for versions. This can lead to maintenance issues. Please revert this to use the ${google.cloud.library.bom.version} property and update the property's value in the <properties> section instead.

Suggested change
<version>26.72.0</version>
<version>${google.cloud.library.bom.version}</version>

@mpeddada1 mpeddada1 changed the title test: update libraries-bom test: update libraries-bom to 26.74.0-rc1 Dec 22, 2025
@mpeddada1
Copy link
Author

/gcbrun

@mpeddada1
Copy link
Author

mpeddada1 commented Dec 22, 2025

Ran mvn -pl gcsio install locally on RC version:

[INFO] Tests run: 30, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 15.929 s - in com.google.cloud.hadoop.gcsio.GoogleCloudStorageReadChannelTest
[INFO] 
[INFO] Results:
[INFO] 
[WARNING] Tests run: 699, Failures: 0, Errors: 0, Skipped: 13
[INFO] 
[INFO] 
[INFO] --- maven-jar-plugin:3.3.0:jar (default-jar) @ gcsio ---
[INFO] 
[INFO] --- maven-jar-plugin:3.3.0:test-jar (default-jar) @ gcsio ---
[INFO] 
[INFO] --- maven-install-plugin:2.4:install (default-install) @ gcsio ---
[INFO] Installing /usr/local/google/home/mpeddada/IdeaProjects/hadoop-connectors/gcsio/target/gcsio-3.0.0-SNAPSHOT.jar to /usr/local/google/home/mpeddada/.m2/repository/com/google/cloud/bigdataoss/gcsio/3.0.0-SNAPSHOT/gcsio-3.0.0-SNAPSHOT.jar
[INFO] Installing /usr/local/google/home/mpeddada/IdeaProjects/hadoop-connectors/gcsio/pom.xml to /usr/local/google/home/mpeddada/.m2/repository/com/google/cloud/bigdataoss/gcsio/3.0.0-SNAPSHOT/gcsio-3.0.0-SNAPSHOT.pom
[INFO] Installing /usr/local/google/home/mpeddada/IdeaProjects/hadoop-connectors/gcsio/target/gcsio-3.0.0-SNAPSHOT-tests.jar to /usr/local/google/home/mpeddada/.m2/repository/com/google/cloud/bigdataoss/gcsio/3.0.0-SNAPSHOT/gcsio-3.0.0-SNAPSHOT-tests.jar
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  01:14 min
[INFO] Finished at: 2025-12-22T16:29:46Z
[INFO] ------------------------------------------------------------------------

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant