test: update libraries-bom to 26.74.0-rc1#1582
test: update libraries-bom to 26.74.0-rc1#1582mpeddada1 wants to merge 3 commits intoGoogleCloudDataproc:masterfrom
Conversation
Summary of ChangesHello @mpeddada1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to standardize and update the project's Google Cloud library dependencies by explicitly setting the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the libraries-bom version. However, instead of updating the google.cloud.library.bom.version property, the version has been hardcoded. This deviates from the practice of managing versions via properties, which is established in this pom.xml and is crucial for maintainability. My review comment suggests reverting this change and updating the property value instead.
pom.xml
Outdated
| <groupId>com.google.cloud</groupId> | ||
| <artifactId>libraries-bom</artifactId> | ||
| <version>${google.cloud.library.bom.version}</version> | ||
| <version>26.72.0</version> |
There was a problem hiding this comment.
Hardcoding the version number here makes it inconsistent with the rest of the project's dependency management, which uses properties for versions. This can lead to maintenance issues. Please revert this to use the ${google.cloud.library.bom.version} property and update the property's value in the <properties> section instead.
| <version>26.72.0</version> | |
| <version>${google.cloud.library.bom.version}</version> |
|
/gcbrun |
|
Ran |
Running
mvn -pl gcsio installis successful with the latest bom version