Adding a local version of google.p12 file#1625
Adding a local version of google.p12 file#1625suryasoma wants to merge 3 commits intoGoogleCloudDataproc:branch-3.1.xfrom
Conversation
…ogle-java-api-client and adding certignaca to it.
Summary of ChangesHello @suryasoma, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request transitions the application's certificate trust mechanism from relying on the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a local google.p12 keystore to use a custom certificate. The changes in pom.xml to handle this binary file are correct. However, in HttpTransportFactory.java, the code to load the keystore introduces a resource leak because the InputStream is not closed. I've provided a comment with a suggested fix that uses a try-with-resources statement to ensure the stream is properly closed and also handles the case where the keystore file might not be found, preventing a potential NullPointerException.
util/src/main/java/com/google/cloud/hadoop/util/HttpTransportFactory.java
Outdated
Show resolved
Hide resolved
|
/gcbrun |
|
/gcbrun |
singhravidutt
left a comment
singhravidutt
left a comment
There was a problem hiding this comment.
Mind adding a test case similar to [GoogleUtilsTest].(https://github.com/googleapis/google-api-java-client/blob/main/google-api-client/src/test/java/com/google/api/client/googleapis/GoogleUtilsTest.java#L29)
| NetHttpTransport.Builder builder = | ||
| new NetHttpTransport.Builder().trustCertificates(GoogleUtils.getCertificateTrustStore()); | ||
|
|
||
| KeyStore keyStore = SecurityUtils.getPkcs12KeyStore(); |
There was a problem hiding this comment.
Blast radius of it could be huge, does it make sense to put this change behind a flag and slowly deprecate it?
| /** Factory for creating HttpTransport types. */ | ||
| public class HttpTransportFactory { | ||
| private static final GoogleLogger logger = GoogleLogger.forEnclosingClass(); | ||
| private static final String KEYSTORE_FILE_NAME = "google.p12"; |
There was a problem hiding this comment.
Given it is going to be used just one it's fine to jsut hardcode it.
Also, we need to package the google.p12 relative to HttpTransportFactory. is it verified?
|
@suryasoma Can this PR be raised against the master branch? We use master for development and port commits to release branches. Also, the latest release branch is 4.0.x, not 3.1.x. |
Not sure if we want to keep it on long term. Idea is to unlock customer as of now. Maintaining the certificate file will be a huge tech debt. |
3 participants
Adding a local version of google.p12 keystore file, which is extracted from google-java-api-client and added Certigna CA certificate to it.
The default
GoogleUtils.getCertificateTrustStore(), does not have Certigna ca cert which is needed for TPC in it.google-java-api-clientteam has said, they will no longer support this keystore, rather mentioned for us to have this local copy in the interim and then move to read from the Java Keystore.