-
Notifications
You must be signed in to change notification settings - Fork 272
Create CODEOWNERS and add multi-approvers #1777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| [ | ||
| {"login": "rajeevpodar"}, | ||
| {"login": "ShreyasSinha"}, | ||
| {"login": "ajayky-os"}, | ||
| {"login": "chandra-siri"}, | ||
| {"login": "prudhvimaharishi"}, | ||
| {"login": "animesh-g"}, | ||
| {"login": "Dhriti07"}, | ||
| {"login": "suni72"}, | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can remove sun72. She has transitioned to a different team. |
||
| {"login": "shrutisinghania"}, | ||
| {"login": "dheerajsngh"}, | ||
| {"login": "cpriti-os"}, | ||
| {"login": "nidhiii-27"}, | ||
| {"login": "singhravidutt"} | ||
| ] | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| name: 'multi-approvers' | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: | ||
| - 'opened' | ||
| - 'edited' | ||
| - 'reopened' | ||
| - 'synchronize' | ||
| - 'ready_for_review' | ||
| - 'review_requested' | ||
| - 'review_request_removed' | ||
| pull_request_review: | ||
| types: | ||
| - 'submitted' | ||
| - 'dismissed' | ||
|
|
||
| # Ensure only one run per PR is active to reduce API consumption | ||
| concurrency: | ||
| group: '${{ github.workflow }}-${{ github.head_ref || github.ref }}' | ||
| cancel-in-progress: true | ||
|
|
||
| permissions: | ||
| actions: 'write' | ||
| contents: 'read' | ||
| pull-requests: 'read' | ||
|
|
||
| jobs: | ||
| multi-approvers: | ||
| runs-on: 'ubuntu-latest' | ||
| steps: | ||
| - name: 'Checkout Repository' | ||
| uses: 'actions/checkout@v4' | ||
|
Check failure on line 33 in .github/workflows/multi-approvers.yml
|
||
|
|
||
| - name: 'Check Two-Party Review Status' | ||
| uses: 'abcxyz/actions/.github/actions/multi-approvers@main' | ||
|
Check failure on line 36 in .github/workflows/multi-approvers.yml
|
||
| with: | ||
| # Path to the JSON file holding the list of Google/internal GitHub usernames | ||
| org-members-path: '.github/workflows/members.json' | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| * @GoogleCloudPlatform/gcs-connector @singhravidutt | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This might not work since the repo is owned by |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we already have the CODEOWNERS defined, why is this file needed again?