Merge master changes into analytics-core-integration branch

[dheerajsngh]

Merge master changes into analytics-core-integration

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates the Analytics Core write path into the GCS Connector, enabling improved performance and functionality by replacing legacy storage channels when the feature flag is enabled. The changes include dependency updates, extensive configuration mapping enhancements, and the introduction of a synchronized wrapper to ensure thread safety during write operations. Comprehensive testing has been added to ensure the reliability of the new write path integration.

Highlights

• Analytics Core Write Path Integration: Integrated the Analytics Core write path into GoogleHadoopOutputStream, allowing for optimized storage operations when enabled.
• Dependency Upgrades: Upgraded google-analyticscore to version 1.5.0 and added the Caffeine caching library with necessary shading configurations.
• Configuration Mapping: Expanded AnalyticsCoreConfigMapper to support a wide range of new configuration properties for read and write path tuning.
• Thread-Safe Wrapper: Introduced GcsAnalyticsCoreOutputStreamWrapper to provide a synchronized, thread-safe interface for the non-thread-safe Analytics Core output stream.
• Testing: Added comprehensive integration and unit tests to validate the new write path functionality and configuration mappings.

New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces support for the GCS Analytics Core write path, including configuration mapping, an output stream wrapper, and integration tests. Feedback on the changes suggests removing redundant synchronization and high-frequency logging from the output stream wrapper, implementing lazy initialization for the analytics filesystem to respect configuration settings, and updating the unit tests to verify close idempotency rather than enforcing synchronization.

[sonarqubecloud]

Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[dheerajsngh]

/gcbrun

[shrutisinghania]

@dheerajsngh Can we merge the feature branch analytics-core-migration instead to migrate these changes to master

[codecov]

Codecov Report

❌ Patch coverage is 74.15459% with 107 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (analytics-core-migration@98d3d3c). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
...adoop/gcsio/GoogleCloudStorageBidiReadChannel.java	73.65%	33 Missing and 11 partials ⚠️
...oud/hadoop/gcsio/GoogleCloudStorageClientImpl.java	72.38%	18 Missing and 11 partials ⚠️
...le/cloud/hadoop/fs/gcs/GoogleHadoopFileSystem.java	13.04%	19 Missing and 1 partial ⚠️
...ogle/cloud/hadoop/gcsio/StorageClientProvider.java	73.68%	2 Missing and 3 partials ⚠️
...gle/cloud/hadoop/gcsio/GoogleCloudStorageImpl.java	80.00%	1 Missing and 3 partials ⚠️
...ud/hadoop/gcsio/GoogleCloudStorageReadChannel.java	88.88%	0 Missing and 2 partials ⚠️
.../google/cloud/hadoop/gcsio/GoogleCloudStorage.java	66.66%	1 Missing ⚠️
...loud/hadoop/util/GcsReadDurationTrackerStream.java	83.33%	0 Missing and 1 partial ⚠️
...google/cloud/hadoop/util/HttpTransportFactory.java	88.88%	1 Missing ⚠️

Additional details and impacted files

@@                     Coverage Diff                     @@
##             analytics-core-migration    #1779   +/-   ##
===========================================================
  Coverage                            ?   82.20%           
  Complexity                          ?     2666           
===========================================================
  Files                               ?      137           
  Lines                               ?    11959           
  Branches                            ?     1479           
===========================================================
  Hits                                ?     9831           
  Misses                              ?     1517           
  Partials                            ?      611           

Flag	Coverage Δ
integrationtest	67.09% <42.02%> (?)
unittest	73.43% <73.18%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[dheerajsngh]

/gcbrun

[dheerajsngh]

/gcbrun

[dheerajsngh]

/gcbrun