Skip to content

fix: Revert the exception message fix in SC 1.0 - #147

Merged
medb merged 5 commits into
mainfrom
revert
Sep 30, 2025
Merged

fix: Revert the exception message fix in SC 1.0#147
medb merged 5 commits into
mainfrom
revert

Conversation

@fangyh20

@fangyh20 fangyh20 commented Sep 30, 2025

Copy link
Copy Markdown
Member

revert #136 in main branch. tested SC 1.0 in jupyter workbench can display error without the change.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @fangyh20, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily reverts a previous change related to custom exception message formatting within IPython environments for DataprocSparkConnectException, streamlining the exception handling mechanism. It also adjusts how this custom exception renders its traceback. Additionally, an integration test for PyPI package installation has been temporarily disabled, acknowledging that the feature is not yet ready for testing.

Highlights

  • Reverted IPython Exception Handling: The custom IPython exception handler, which was previously implemented to provide a simplified traceback for DataprocSparkConnectException by only displaying the error message, has been removed. This also removes the associated sys and IPython imports.
  • Modified Exception Traceback Rendering: The _render_traceback_ method within the DataprocSparkConnectException class has been updated to return the exception message directly as a string, rather than encapsulating it within a list.
  • Skipped PyPI Package Installation Test: An integration test, test_add_artifacts_pypi_package, has been temporarily skipped. This is because the functionality for installing PyPI packages is not yet supported.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reverts a custom exception handler for IPython environments, which involved monkey-patching showtraceback. This is a good simplification, relying instead on IPython's _render_traceback_ hook. However, there is an error in the implementation of _render_traceback_ which will cause exceptions to be displayed incorrectly. I've also noted the skipping of an integration test, which seems appropriate given the feature revert. My main feedback is to correct the return type of _render_traceback_.

Comment thread google/cloud/dataproc_spark_connect/exceptions.py Outdated
fangyh20 and others added 2 commits September 30, 2025 13:40
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@medb medb changed the title Revert the execption message fix in SC 1.0 fix: Revert the exception message fix in SC 1.0 Sep 30, 2025
@medb
medb merged commit 21b6239 into main Sep 30, 2025
4 checks passed
@medb
medb deleted the revert branch September 30, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants