Use Java Standard Interface to fix the cast exception #1459
Conversation
… from shading configuration.
Summary of ChangesHello @yalimu-g, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a class casting issue by modifying the Maven shading configuration. It ensures that the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses a potential ClassCastException by ensuring the com.google.cloud.bigquery.connector.common package is properly shaded with other dependencies. The change, made in spark-bigquery-parent/pom.xml, involves modifying the maven-shade-plugin configuration. While the approach of commenting out the exclusion is a valid way to test the fix, my feedback suggests removing the commented code entirely for better long-term maintainability before merging.
spark-bigquery-parent/pom.xml
Outdated
| <!-- the bigquery connector common library needs to be repackaged --> | ||
| <!-- <exclude>com.google.cloud.bigquery.connector.common.**</exclude> --> |
There was a problem hiding this comment.
To improve maintainability, it's better to remove this configuration entirely rather than commenting it out. The pull request description and commit message already provide sufficient context for this change. As you mentioned you would remove the commented code after confirming the fix, it would be ideal to do so before this pull request is merged.
|
/gcbrun |
…terfaces for parameters and return types, and exclude the common connector from shading.
|
/gcbrun |
|
/gcbrun |
yalimu-g
changed the title
com.google.cloud.bigquery.connector.common to fix the cast exception
...or-common/src/main/java/com/google/cloud/bigquery/connector/common/QueryParameterHelper.java
Outdated
Show resolved
Hide resolved
|
/gcbrun |
3 participants
The com.google.cloud.bigquery.connector.common package should be relocated along with the rest of the dependencies. This ensures that the code within the shaded connector strictly uses its own internal, shaded versions of the classes, avoiding conflicts with any unshaded libraries on the classpath.
If this fixes the issue of #1458 , I will remove the commented code.