Add kms key to Bigquery config to be used in query

[yalimu-g]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @yalimu-g, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the BigQuery connector by enabling users to specify a Customer-Managed Encryption Key (CMEK) for temporary tables created during query materialization. This feature allows for greater control over data security by ensuring that intermediate query results are encrypted using a user-provided key, aligning with enterprise security requirements.

Highlights

• KMS Key Integration: Added support for specifying a Customer-Managed Encryption Key (CMEK) when materializing BigQuery query results into temporary tables.
• API Extension: Modified BigQueryClient methods (materializeQueryToTable, getQueryResultSchema) and the ReadTableOptions interface to accept an optional KMS key name.
• Test Coverage: Included new unit and integration tests to ensure correct propagation and application of the KMS key during query execution.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request successfully introduces the functionality to specify a KMS key for BigQuery queries that materialize to temporary tables. This is a valuable security enhancement, allowing users to encrypt their temporary query results with customer-managed encryption keys. The changes involve propagating the KMS key name through various method calls and configurations, and applying it when building QueryJobConfiguration objects. New overloaded methods and a default method in an interface ensure backward compatibility. Comprehensive unit and integration tests have been added to validate the new functionality.

[gemini-code-assist]

The assertion for the KMS key name assumes a specific suffix (/cryptoKeyVersions/1). This might be too rigid. If the provided kmsKeyName is already a full resource name including a version, or if BigQuery's API returns the key name without a version suffix in some cases, this test could fail unnecessarily. It would be more robust to assert that the getKmsKeyName() value contains the provided kmsKeyName or matches it exactly if no version is expected to be appended by the API. Consider using startsWith or a more flexible comparison.

Suggested change

	assertThat(
	((QueryJobConfiguration) jobInfo.getConfiguration())
	.getDestinationEncryptionConfiguration()
	.getKmsKeyName())
	.isEqualTo(kmsKeyName + "/cryptoKeyVersions/1");
	assertThat(
	((QueryJobConfiguration) jobInfo.getConfiguration())
	.getDestinationEncryptionConfiguration()
	.getKmsKeyName())
	.startsWith(kmsKeyName);

[yalimu-g]

/gcbrun

[BoqianShi]

LGTM

[yalimu-g]

/gcbrun