-
Notifications
You must be signed in to change notification settings - Fork 220
add logging for dpo #1462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
add logging for dpo #1462
Conversation
Summary of ChangesHello @isha97, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on improving the observability and debuggability of data write operations, particularly those involving dynamic partition overwrites in the BigQuery connector. By introducing comprehensive logging at key stages, including method entry points, partition detection, query execution, and condition checks, the changes aim to provide clearer insights into the system's behavior, making it easier to diagnose issues and understand the flow of data writes to BigQuery. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds several info level log statements to aid in debugging dynamic partition overwrites. While most of the logging is helpful, there are a few instances where stack traces are being logged at the INFO level. This is generally discouraged in production code due to performance overhead and log verbosity. I've recommended changing these to DEBUG level. Additionally, I've suggested lowering the log level for a statement that logs a full SQL query to DEBUG to prevent potential sensitive data exposure and reduce log noise.
No description provided.