Refactor pipeline parameter options to seperate Options.java file

v2/datastream-to-spanner/src/main/java/com/google/cloud/teleport/v2/options/package-info.java

@@ -0,0 +1,18 @@
+/*
+ * Copyright (C) 2026 Google LLC
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not
+ * use this file except in compliance with the License. You may obtain a copy of
+ * the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations under
+ * the License.
+ */
+
+/** Options classes. */
+package com.google.cloud.teleport.v2.options;

v2/datastream-to-spanner/src/test/java/com/google/cloud/teleport/v2/templates/DataStreamToSpannerTest.java

@@ -28,6 +28,7 @@
 import com.google.api.services.datastream.v1.model.OracleSourceConfig;
 import com.google.api.services.datastream.v1.model.PostgresqlSourceConfig;
 import com.google.api.services.datastream.v1.model.SourceConfig;
+import com.google.cloud.teleport.v2.options.DataStreamToSpannerOptions;
 import com.google.cloud.teleport.v2.spanner.migrations.constants.Constants;
 import com.google.cloud.teleport.v2.spanner.migrations.schema.ISchemaOverridesParser;
 import com.google.cloud.teleport.v2.spanner.migrations.schema.NoopSchemaOverridesParser;
@@ -50,10 +51,8 @@ public class DataStreamToSpannerTest {
   @Test
   public void testGetSourceTypeWithDatastreamSourceType() {
     String[] args = new String[] {"--datastreamSourceType=mysql"};
-    DataStreamToSpanner.Options options =
-        PipelineOptionsFactory.fromArgs(args)
-            .withValidation()
-            .as(DataStreamToSpanner.Options.class);
+    DataStreamToSpannerOptions options =
+        PipelineOptionsFactory.fromArgs(args).withValidation().as(DataStreamToSpannerOptions.class);
     String result = DataStreamToSpanner.getSourceType(options);
 
     assertEquals("mysql", result);
@@ -63,10 +62,8 @@ public void testGetSourceTypeWithDatastreamSourceType() {
   public void testGetSourceTypeWithDatastreamInputFilePattern() {
     String[] args =
         new String[] {"--inputFilePattern=gs://test-bkt/", "--directoryWatchDurationInMinutes=42"};
-    DataStreamToSpanner.Options options =
-        PipelineOptionsFactory.fromArgs(args)
-            .withValidation()
-            .as(DataStreamToSpanner.Options.class);
+    DataStreamToSpannerOptions options =
+        PipelineOptionsFactory.fromArgs(args).withValidation().as(DataStreamToSpannerOptions.class);
     String inputFilePattern = options.getInputFilePattern();
     Integer directoryWatchDurationInMinutes = options.getDirectoryWatchDurationInMinutes();
     Integer expectedWatchDuration = 42;
@@ -80,10 +77,8 @@ public void testGetSourceTypeWithEmptyStreamName() {
     expectedEx.expect(IllegalArgumentException.class);
     expectedEx.expectMessage("Stream name cannot be empty.");
     String[] args = new String[] {""};
-    DataStreamToSpanner.Options options =
-        PipelineOptionsFactory.fromArgs(args)
-            .withValidation()
-            .as(DataStreamToSpanner.Options.class);
+    DataStreamToSpannerOptions options =
+        PipelineOptionsFactory.fromArgs(args).withValidation().as(DataStreamToSpannerOptions.class);
     String result = DataStreamToSpanner.getSourceType(options);
   }
 
@@ -95,16 +90,21 @@ public void testGetSourceTypeWithGcpCredentialsMissing() {
         new String[] {
           "--streamName=projects/sample-project/locations/sample-location/streams/sample-stream"
         };
-    DataStreamToSpanner.Options options =
-        PipelineOptionsFactory.fromArgs(args)
-            .withValidation()
-            .as(DataStreamToSpanner.Options.class);
+    DataStreamToSpannerOptions options =
+        PipelineOptionsFactory.fromArgs(args).withValidation().as(DataStreamToSpannerOptions.class);
     String result = DataStreamToSpanner.getSourceType(options);
   }
 
+  @Test
+  public void testGetShardingContext_Empty() {
+    DataStreamToSpannerOptions options = mock(DataStreamToSpannerOptions.class);
+    when(options.getSourceConfigURL()).thenReturn("");
+    assertNotNull(DataStreamToSpanner.getShardingContext(options));
+  }
+
   @Test
   public void testConfigureSchemaOverrides_fileBased() {
-    DataStreamToSpanner.Options options = mock(DataStreamToSpanner.Options.class);
+    DataStreamToSpannerOptions options = mock(DataStreamToSpannerOptions.class);
     when(options.getSchemaOverridesFilePath())
         .thenReturn(
             Resources.getResource("DataStreamToSpannerFileOverridesIT/override.json").getPath());
@@ -125,7 +125,7 @@ public void testConfigureSchemaOverrides_fileBased() {
 
   @Test
   public void testConfigureSchemaOverrides_stringBased() {
-    DataStreamToSpanner.Options options = mock(DataStreamToSpanner.Options.class);
+    DataStreamToSpannerOptions options = mock(DataStreamToSpannerOptions.class);
     when(options.getSchemaOverridesFilePath()).thenReturn("");
     when(options.getTableOverrides()).thenReturn("[{person1, human1}]");
     when(options.getColumnOverrides()).thenReturn("[{person1.first_name1, person1.name1}]");
@@ -144,7 +144,7 @@ public void testConfigureSchemaOverrides_stringBased() {
 
   @Test
   public void testConfigureSchemaOverrides_noOverrides() {
-    DataStreamToSpanner.Options options = mock(DataStreamToSpanner.Options.class);
+    DataStreamToSpannerOptions options = mock(DataStreamToSpannerOptions.class);
     when(options.getSchemaOverridesFilePath()).thenReturn("");
     when(options.getTableOverrides()).thenReturn("");
     when(options.getColumnOverrides()).thenReturn("");
@@ -156,7 +156,7 @@ public void testConfigureSchemaOverrides_noOverrides() {
 
   @Test
   public void testConfigureSchemaOverrides_incorrectConfiguration() {
-    DataStreamToSpanner.Options options = mock(DataStreamToSpanner.Options.class);
+    DataStreamToSpannerOptions options = mock(DataStreamToSpannerOptions.class);
     when(options.getSchemaOverridesFilePath()).thenReturn("/path/to/overrides.json");
     when(options.getTableOverrides()).thenReturn("table1=schema1");
 
@@ -167,7 +167,7 @@ public void testConfigureSchemaOverrides_incorrectConfiguration() {
 
   @Test
   public void testConfigureSchemaOverrides_onlyTableOverrides() {
-    DataStreamToSpanner.Options options = mock(DataStreamToSpanner.Options.class);
+    DataStreamToSpannerOptions options = mock(DataStreamToSpannerOptions.class);
     when(options.getSchemaOverridesFilePath()).thenReturn("");
     when(options.getTableOverrides()).thenReturn("[{person1, human1}]");
     when(options.getColumnOverrides()).thenReturn("");
@@ -179,7 +179,7 @@ public void testConfigureSchemaOverrides_onlyTableOverrides() {
 
   @Test
   public void testConfigureSchemaOverrides_onlyColumnOverrides() {
-    DataStreamToSpanner.Options options = mock(DataStreamToSpanner.Options.class);
+    DataStreamToSpannerOptions options = mock(DataStreamToSpannerOptions.class);
     when(options.getSchemaOverridesFilePath()).thenReturn("");
     when(options.getTableOverrides()).thenReturn("");
     when(options.getColumnOverrides()).thenReturn("[{person1.first_name1, person1.name1}]");
@@ -191,7 +191,7 @@ public void testConfigureSchemaOverrides_onlyColumnOverrides() {
 
   @Test
   public void testConfigureSchemaOverrides_incorrectConfiguration_columnOverrides() {
-    DataStreamToSpanner.Options options = mock(DataStreamToSpanner.Options.class);
+    DataStreamToSpannerOptions options = mock(DataStreamToSpannerOptions.class);
     when(options.getSchemaOverridesFilePath()).thenReturn("/path/to/overrides.json");
     when(options.getTableOverrides()).thenReturn("");
     when(options.getColumnOverrides()).thenReturn("col1=col2");
@@ -203,7 +203,7 @@ public void testConfigureSchemaOverrides_incorrectConfiguration_columnOverrides(
 
   @Test
   public void testValidateSourceType_validSource() {
-    DataStreamToSpanner.Options options = mock(DataStreamToSpanner.Options.class);
+    DataStreamToSpannerOptions options = mock(DataStreamToSpannerOptions.class);
     when(options.getRunMode()).thenReturn("");
     when(options.getDatastreamSourceType()).thenReturn("mysql");
 
@@ -214,7 +214,7 @@ public void testValidateSourceType_validSource() {
 
   @Test
   public void testValidateSourceType_invalidSource() {
-    DataStreamToSpanner.Options options = mock(DataStreamToSpanner.Options.class);
+    DataStreamToSpannerOptions options = mock(DataStreamToSpannerOptions.class);
     when(options.getRunMode()).thenReturn("");
     when(options.getDatastreamSourceType()).thenReturn("invalid_source");
 
@@ -224,7 +224,7 @@ public void testValidateSourceType_invalidSource() {
 
   @Test
   public void testValidateSourceType_retryMode() {
-    DataStreamToSpanner.Options options = mock(DataStreamToSpanner.Options.class);
+    DataStreamToSpannerOptions options = mock(DataStreamToSpannerOptions.class);
     when(options.getRunMode()).thenReturn(Constants.RUN_MODE_RETRY_DLQ);
 
     DataStreamToSpanner.validateSourceType(options);
@@ -234,7 +234,7 @@ public void testValidateSourceType_retryMode() {
 
   @Test
   public void testGetShadowTableSpannerConfig_validInput() {
-    DataStreamToSpanner.Options options = mock(DataStreamToSpanner.Options.class);
+    DataStreamToSpannerOptions options = mock(DataStreamToSpannerOptions.class);
     when(options.getShadowTableSpannerInstanceId()).thenReturn("shadow-instance-id");
     when(options.getShadowTableSpannerDatabaseId()).thenReturn("shadow-database-id");
     when(options.getProjectId()).thenReturn("project-id");
@@ -248,7 +248,7 @@ public void testGetShadowTableSpannerConfig_validInput() {
 
   @Test
   public void testGetShadowTableSpannerConfig_missingInstanceId() {
-    DataStreamToSpanner.Options options = mock(DataStreamToSpanner.Options.class);
+    DataStreamToSpannerOptions options = mock(DataStreamToSpannerOptions.class);
     when(options.getShadowTableSpannerInstanceId()).thenReturn("");
     when(options.getShadowTableSpannerDatabaseId()).thenReturn("shadow-database-id");
 
@@ -259,7 +259,7 @@ public void testGetShadowTableSpannerConfig_missingInstanceId() {
 
   @Test
   public void testGetShadowTableSpannerConfig_missingDatabaseId() {
-    DataStreamToSpanner.Options options = mock(DataStreamToSpanner.Options.class);
+    DataStreamToSpannerOptions options = mock(DataStreamToSpannerOptions.class);
     when(options.getShadowTableSpannerInstanceId()).thenReturn("shadow-instance-id");
     when(options.getShadowTableSpannerDatabaseId()).thenReturn("");
 
@@ -270,7 +270,7 @@ public void testGetShadowTableSpannerConfig_missingDatabaseId() {
 
   @Test
   public void testGetShadowTableSpannerConfig_defaultValues() {
-    DataStreamToSpanner.Options options = mock(DataStreamToSpanner.Options.class);
+    DataStreamToSpannerOptions options = mock(DataStreamToSpannerOptions.class);
     when(options.getShadowTableSpannerInstanceId()).thenReturn("");
     when(options.getShadowTableSpannerDatabaseId()).thenReturn("");
     when(options.getInstanceId()).thenReturn("main-instance-id");
@@ -286,7 +286,7 @@ public void testGetShadowTableSpannerConfig_defaultValues() {
 
   @Test
   public void testBuildDlqManager_defaultTempLocation() {
-    DataStreamToSpanner.Options options = mock(DataStreamToSpanner.Options.class);
+    DataStreamToSpannerOptions options = mock(DataStreamToSpannerOptions.class);
     DataflowPipelineOptions dfOptions = mock(DataflowPipelineOptions.class);
     when(options.as(DataflowPipelineOptions.class)).thenReturn(dfOptions);
     when(dfOptions.getTempLocation()).thenReturn("/tmp/test-bucket/temp");
@@ -300,7 +300,7 @@ public void testBuildDlqManager_defaultTempLocation() {
 
   @Test
   public void testBuildDlqManager_tempLocationWithTrailingSlash() {
-    DataStreamToSpanner.Options options = mock(DataStreamToSpanner.Options.class);
+    DataStreamToSpannerOptions options = mock(DataStreamToSpannerOptions.class);
     DataflowPipelineOptions dfOptions = mock(DataflowPipelineOptions.class);
     when(options.as(DataflowPipelineOptions.class)).thenReturn(dfOptions);
     when(dfOptions.getTempLocation()).thenReturn("/tmp/test-bucket/temp/");
@@ -314,7 +314,7 @@ public void testBuildDlqManager_tempLocationWithTrailingSlash() {
 
   @Test
   public void testBuildDlqManager_withDlqDirectory() {
-    DataStreamToSpanner.Options options = mock(DataStreamToSpanner.Options.class);
+    DataStreamToSpannerOptions options = mock(DataStreamToSpannerOptions.class);
     DataflowPipelineOptions dfOptions = mock(DataflowPipelineOptions.class);
     when(options.as(DataflowPipelineOptions.class)).thenReturn(dfOptions);
     when(dfOptions.getTempLocation()).thenReturn("/tmp/test-bucket/temp");
@@ -349,8 +349,8 @@ public void testBuildPipeline() throws Exception {
           "--workerMachineType=n1-standard-4"
         };
 
-    DataStreamToSpanner.Options options =
-        PipelineOptionsFactory.fromArgs(args).as(DataStreamToSpanner.Options.class);
+    DataStreamToSpannerOptions options =
+        PipelineOptionsFactory.fromArgs(args).as(DataStreamToSpannerOptions.class);
 
     Pipeline pipeline = DataStreamToSpanner.buildPipeline(options);
 
@@ -380,8 +380,8 @@ public void testBuildPipeline_retryDLQ() throws Exception {
           "--workerMachineType=n1-standard-4"
         };
 
-    DataStreamToSpanner.Options options =
-        PipelineOptionsFactory.fromArgs(args).as(DataStreamToSpanner.Options.class);
+    DataStreamToSpannerOptions options =
+        PipelineOptionsFactory.fromArgs(args).as(DataStreamToSpannerOptions.class);
 
     Pipeline pipeline = DataStreamToSpanner.buildPipeline(options);
 
@@ -411,8 +411,8 @@ public void testBuildPipeline_retryAllDLQ() throws Exception {
           "--workerMachineType=n1-standard-4"
         };
 
-    DataStreamToSpanner.Options options =
-        PipelineOptionsFactory.fromArgs(args).as(DataStreamToSpanner.Options.class);
+    DataStreamToSpannerOptions options =
+        PipelineOptionsFactory.fromArgs(args).as(DataStreamToSpannerOptions.class);
 
     Pipeline pipeline = DataStreamToSpanner.buildPipeline(options);
 
@@ -443,8 +443,8 @@ public void testBuildPipeline_withDlqGcsPubSubSubscription() throws Exception {
           "--dlqGcsPubSubSubscription=projects/project-id/subscriptions/sub-id"
         };
 
-    DataStreamToSpanner.Options options =
-        PipelineOptionsFactory.fromArgs(args).as(DataStreamToSpanner.Options.class);
+    DataStreamToSpannerOptions options =
+        PipelineOptionsFactory.fromArgs(args).as(DataStreamToSpannerOptions.class);
 
     Pipeline pipeline = DataStreamToSpanner.buildPipeline(options);
 
@@ -517,8 +517,8 @@ public void testBuildPipeline_withAllOptions() throws Exception {
           "--shadowTableSpannerDatabaseId=shadow-database-id" // Set shadow database
         };
 
-    DataStreamToSpanner.Options options =
-        PipelineOptionsFactory.fromArgs(args).as(DataStreamToSpanner.Options.class);
+    DataStreamToSpannerOptions options =
+        PipelineOptionsFactory.fromArgs(args).as(DataStreamToSpannerOptions.class);
 
     Pipeline pipeline = DataStreamToSpanner.buildPipeline(options);