fix(spanner): skip locality group option in information schema until full support - #4216
fix(spanner): skip locality group option in information schema until full support#4216finnzzf wants to merge 3 commits into
Conversation
…in column options
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the integration tests for the Spanner information schema scanner to accommodate upcoming changes in how locality groups are represented in column options. By broadening the assertion criteria, the tests are now resilient to the transition period where both old and new DDL formats may be encountered. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the integration tests in InformationSchemaScannerIT.java to accommodate variations in Spanner DDL outputs where columns may optionally include OPTIONS (locality_group="default") or OPTIONS (locality_group='default'). It achieves this by utilizing Hamcrest's anyOf matcher in the assertions for both GoogleSQL and PostgreSQL dialects. I have no feedback to provide.
…y group in column options" This reverts commit 86dc5fb. And add logic to skip adding locality group into DDL for now until the change is fully rolled out and locality group support is added in the template repo.
…lity group option is added and the feature is rolled out.
|
since the locality_group information_schema enhancement is not yet fully rolled out, and the locality group option support is not in the dataflow repo, the proposed workaround for now is preventing locality group to show up in the DDL until the support is in place. |
Update information schema IT to accept default locality group in column options.
The test is updated to accept both old and new formats until the change is fully rolled out in spanner release.