Skip to content

fix(spanner): skip locality group option in information schema until full support - #4216

Open
finnzzf wants to merge 3 commits into
GoogleCloudPlatform:mainfrom
finnzzf:main
Open

fix(spanner): skip locality group option in information schema until full support#4216
finnzzf wants to merge 3 commits into
GoogleCloudPlatform:mainfrom
finnzzf:main

Conversation

@finnzzf

@finnzzf finnzzf commented Sep 3, 2026

Copy link
Copy Markdown

Update information schema IT to accept default locality group in column options.

The test is updated to accept both old and new formats until the change is fully rolled out in spanner release.

@finnzzf
finnzzf requested a review from a team as a code owner September 3, 2026 00:41
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the integration tests for the Spanner information schema scanner to accommodate upcoming changes in how locality groups are represented in column options. By broadening the assertion criteria, the tests are now resilient to the transition period where both old and new DDL formats may be encountered.

Highlights

  • Test Compatibility: Updated InformationSchemaScannerIT to support both legacy and new Spanner locality group formats, ensuring tests remain green during the rollout.
  • Assertion Logic: Modified test assertions to use Hamcrest's anyOf matcher, allowing the schema validation to accept either the standard or the new locality-aware DDL statements.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the integration tests in InformationSchemaScannerIT.java to accommodate variations in Spanner DDL outputs where columns may optionally include OPTIONS (locality_group="default") or OPTIONS (locality_group='default'). It achieves this by utilizing Hamcrest's anyOf matcher in the assertions for both GoogleSQL and PostgreSQL dialects. I have no feedback to provide.

…y group in column options"

This reverts commit 86dc5fb.

And add logic to skip adding locality group into DDL for now until the change is fully rolled out and locality group support is added in the template repo.
@pull-request-size pull-request-size Bot added size/XS and removed size/M labels Sep 3, 2026
…lity group option is added and the feature is rolled out.
@finnzzf finnzzf changed the title fix(spanner): information schema IT to accept default locality group fix(spanner): skip locality group option in information schema until full support Sep 3, 2026
@finnzzf

finnzzf commented Sep 3, 2026

Copy link
Copy Markdown
Author

since the locality_group information_schema enhancement is not yet fully rolled out, and the locality group option support is not in the dataflow repo, the proposed workaround for now is preventing locality group to show up in the DDL until the support is in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant