improvement: expose wait timeout - #4221
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new configuration parameter, Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new optional parameter 'bigtableReadPartialRowTimeoutMs' to configure the read partial row timeout for Bigtable, and updates the 'bigtable-beam-import.version' dependency to '2.20.1'. The review feedback points out that the README file was modified manually; since this file is auto-generated, these manual changes should be reverted and regenerated using the template utility.
| export BIGTABLE_READ_RPC_TIMEOUT_MS=<bigtableReadRpcTimeoutMs> | ||
| export BIGTABLE_READ_RPC_ATTEMPT_TIMEOUT_MS=<bigtableReadRpcAttemptTimeoutMs> | ||
| export BIGTABLE_MAX_ATTEMPTS=<bigtableMaxAttempts> | ||
| export BIGTABLE_READ_PARTIAL_ROW_TIMEOUT_MS=<bigtableReadPartialRowTimeoutMs> |
There was a problem hiding this comment.
The README_Cloud_Bigtable_to_GCS_SequenceFile.md file is auto-generated from the template metadata annotations (as noted on line 16: 'Do not change this file directly.'). Manual changes to this file will be overwritten during the next build/generation cycle. Please revert the manual changes to this file and instead run the template utility (e.g., using the templatesSpec Maven profile) to regenerate the README automatically.
References
- Do not manually edit generated documentation files (such as READMEs generated from Metadata Annotations). Any corrections, such as incorrect directory paths, should be made in the generator code or source annotations.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4221 +/- ##
============================================
- Coverage 55.93% 55.93% -0.01%
+ Complexity 7482 7031 -451
============================================
Files 1134 1134
Lines 70175 70175
Branches 8023 8023
============================================
- Hits 39255 39253 -2
- Misses 28371 28373 +2
Partials 2549 2549
🚀 New features to boost your workflow:
|
|
Just note that additional-pipeline-option is now supported for classic templates. User can use to pass a runtime pipeline option for a classic template invocation. |
|
@Abacn This is awesome, but we'll still need to update the dependency version. I noticed some dependency issue during testing. So will update the bigtable client first. |
No description provided.