chore: update utcnow to now(timezone.utc)
#189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackwotherspoon
requested review from
cthumuluru,
nancynh and
a team
as code owners
jackwotherspoon
commented
Dec 21, 2023
| @@ -92,7 +92,7 @@ def __init__( | |||
| ca_cert, cert_chain = certs | |||
| # get expiration from client certificate | |||
| cert_obj = x509.load_pem_x509_certificate(cert_chain[0].encode("UTF-8")) | |||
| self.expiration = cert_obj.not_valid_after | |||
| self.expiration = cert_obj.not_valid_after.replace(tzinfo=timezone.utc) | |||
There was a problem hiding this comment.
Cert is in UTC "Zulu" format so making it timezone aware for utc is fine here (basically a no-op).
https://cloud.google.com/sql/docs/mysql/admin-api/rest/v1beta4/sslCerts#SslCert
enocom
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Python 3.12 the use of
utcnow()is deprecated. https://discuss.python.org/t/deprecating-utcnow-and-utcfromtimestamp/26221This also updates the timestamps from naive timestamps to aware timestamps.