fix: asmcli doesnt work without readlink binary on bsd-style OS #1320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuisFigueiredo2021
approved these changes
Sep 9, 2022
paulo-hs
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
./asmclion a macos system returns an error since kpt isn't properly configured.As the commented line in the script says, the
statdoesn't have the same behavior asreadlink. It's required to usereadlinkto set the right path for kpt.Using readlink (after installing using
brew install coreutils) the script works as expected.The option to install
kptmanually doesn't work either. The version is fixed onasmclito0.39.3and there are breaking changes in the CLI when we use the latest version.