Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| @@ -0,0 +1,664 @@ | |||
| { | |||
There was a problem hiding this comment.
The link shown here isn't accessible (permission issue). Could you add a process to make it accessible by either making it publicly accessible or using proxy?
Proxy example here:
Reply via ReviewNB
There was a problem hiding this comment.
Added Cloud Shell using a proxy instructions
There was a problem hiding this comment.
Remove this cloud run services describe part if it is not the way to access the app
| @@ -0,0 +1,681 @@ | |||
| { | |||
There was a problem hiding this comment.
I couldn't get the purpose here. Why do you want to run this command and get the service URL? I believe it's not accessible directly anyway.
Reply via ReviewNB
There was a problem hiding this comment.
That is very common question on how to get deployed cloud run service URL to use it for different propose, like automated tests, etc. so would prefer to keep this example it for educational propose
There was a problem hiding this comment.
If so could you clarify the purpose in Markdown? And I think it's good to move this command inside a markdown, instead of keeping in the executable cell, since it's misleading to show a link that doesn't work, and it's nothing to do with the flow of this notebook.
| @@ -0,0 +1,681 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,681 @@ | |||
| { | |||
There was a problem hiding this comment.
It seems Cloud SQL Admin API needs to be enabled to run this command. Add that in this notebook or in setup_on_jupyterlab.sh .
Reply via ReviewNB
| @@ -0,0 +1,681 @@ | |||
| { | |||
There was a problem hiding this comment.
|
@olex-snk |
2 participants
Added ADK deployment to CloudRun solution