adding code for bigquery policy tag extractor#398
Open
karcot1 wants to merge 6 commits intoGoogleCloudPlatform:masterfrom
Open
adding code for bigquery policy tag extractor#398karcot1 wants to merge 6 commits intoGoogleCloudPlatform:masterfrom
karcot1 wants to merge 6 commits intoGoogleCloudPlatform:masterfrom
Conversation
danieldeleo
requested changes
Mar 27, 2024
Collaborator
danieldeleo
left a comment
danieldeleo
left a comment
There was a problem hiding this comment.
Thanks for this contribution @karcot1 ! Can you please move this into the scripts/ directory
Author
|
@danieldeleo done! Please review when you get the chance. Thanks! |
danieldeleo
reviewed
Mar 28, 2024
danieldeleo
reviewed
Mar 28, 2024
danieldeleo
reviewed
Mar 28, 2024
danieldeleo
reviewed
Mar 28, 2024
danieldeleo
reviewed
Mar 28, 2024
Co-authored-by: Daniel De Leo <danieldeleo@users.noreply.github.com>
Author
|
@danieldeleo thanks for the suggested changes! Commits are done and ready for review. |
danieldeleo
requested changes
Apr 1, 2024
|
|
||
| if [ "${TAG_COUNT}" -ge 1 ] | ||
| then | ||
| COLUMN_AND_TAG=`bq show --format=prettyjson ${DATASET}.${TABLE} | jq '.schema.fields[] | select(.policyTags | length>=1)'` |
Collaborator
There was a problem hiding this comment.
This doesn't handle RECORD type columns with nested policy tags. Can you either handle it in code or make an explicit callout in README that this script only handles simple column types.
Author
There was a problem hiding this comment.
@danieldeleo added a line to the Considerations section of the README calling this out. Will work on updating the code to handle nested tags in the future.
Co-authored-by: Daniel De Leo <danieldeleo@users.noreply.github.com>
…oogleCloudPlatform#399) * adding anti pattern recognition step to optimization scripts * using viewable_queries_grouped_by_hash for anti pattern processing * moving anti pattern recognition tool steps to separate script * fixing bug in column names * fixing bug in column names * adding anti pattern script, accounting for null has * adding anti pattern script, supporting multiple executions * adding anti pattern script, addressing duplicate hashes * adding anti pattern script, addressing duplicate hashes * making anti pattern opitmization script generic for any input table, removing query column from queries_grouped_by_hash at org level, adding a project level version of queries_grouped_by_hash * updating readme with examples on how to execute the anti pattern optimization script * updating readme with examples on how to execute the anti pattern optimization script and removing test file * changing location of the anti pattern optimization script for clarity * enhancing readme with instructions to run the anti pattern optimization scripts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR contains two files