Support Workload Identity Federation in IAM configurations#521
Open
hisomura wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
Open
Support Workload Identity Federation in IAM configurations#521hisomura wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
hisomura wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Replace allAuthenticatedUsers with allUsers for all IAM resource permissions
c963d16 to
89befd6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses #518 by replacing
allAuthenticatedUserswithallUsersin all IAM member configurations.Motivation
As discussed in issue #518, users cannot access bqutil resources when using Workload Identity Federation because
allAuthenticatedUsersdoes not include federated identities.According to Google Cloud IAM documentation:
Changes
allAuthenticatedUserstoallUsersinrelease/terraform/main.tfSecurity Consideration
There is minimal security difference between
allAuthenticatedUsersandallUsersfor public resources, asallAuthenticatedUsersincludes any Google account (not just organization members).Fixes #518