Skip to content

Start slurmd in tpu nodes with -N slurmName #3927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -476,6 +476,29 @@ def setup_compute():
slurmd_options.append(f'--conf="Feature={slurmd_feature}"')
slurmd_options.append("-Z")

if os.getenv("OS_ENV") == "slurm_container":
try:
def _extract_slurmd_nodename(slurm_names, tpu_env):
wid = None
for line in tpu_env.splitlines():
if line.startswith('WORKER_ID:'):
wid = line.split(":", 1)[1].strip().strip("'")
if wid is not None:
for pair in slurm_names.split(";"):
if pair.startswith(f"WORKER_{wid}"):
return pair.split(":", 1)[1]
return None

slurm_names = util.instance_metadata("attributes/slurm_names")
tpu_env = util.instance_metadata("attributes/tpu-env")
slurmd_nodename = _extract_slurmd_nodename(slurm_names,tpu_env)

except Exception:
# TODO: differentiate between unset and error
slurmd_nodename = None
if slurmd_nodename is not None:
slurmd_options.append(f'-N {slurmd_nodename}')

sysconf = f"""SLURMD_OPTIONS='{" ".join(slurmd_options)}'"""
update_system_config("slurmd", sysconf)
install_custom_scripts()
Expand Down