Skip to content

Remove firewall rules from IRDMA VPCs #3971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Remove firewall rules from IRDMA VPCs #3971

wants to merge 1 commit into from

Conversation

abbas1902
Copy link
Collaborator

@abbas1902 abbas1902 commented Apr 18, 2025 •
edited
Loading

  • Removal of firewall rules from IRDMA VPCs
  • Enable placement for H4D Slurm blueprint

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@abbas1902 abbas1902 added the release-chore To not include into release notes label Apr 18, 2025
@abbas1902 abbas1902 marked this pull request as ready for review April 18, 2025 22:19
@abbas1902 abbas1902 requested review from samskillman and a team as code owners April 18, 2025 22:19
casassg
casassg reviewed Apr 21, 2025
View reviewed changes
@cdunbar13
Copy link
Collaborator

@abbas1902 You may want to look at PR 3987 as I believe it is a more complete version of what you were going for here.

@abbas1902 abbas1902 changed the title Remove firewall rules from RDMA VPCs Remove firewall rules from IRDMA VPCs Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casassg casassg casassg left review comments

@samskillman samskillman Awaiting requested review from samskillman samskillman is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
release-chore To not include into release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abbas1902 @cdunbar13 @casassg