Skip to content

Parallelstore switch region and update network name #4131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Shuang-cnt
Copy link
Contributor

@Shuang-cnt Shuang-cnt commented May 16, 2025

switch region to us-east4 due to no enough resource and changing the network name in the test to avoid collision with hidden resource

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@Shuang-cnt Shuang-cnt added the release-chore To not include into release notes label May 16, 2025
@Shuang-cnt Shuang-cnt changed the title switch region to us-east4 due to no enought resource and changing the… switch region to us-east4 and update network name May 16, 2025
@Shuang-cnt Shuang-cnt changed the title switch region to us-east4 and update network name PS switch region and update network name May 16, 2025
@Shuang-cnt Shuang-cnt changed the title PS switch region and update network name Parallelstore switch region and update network name May 16, 2025
@Shuang-cnt Shuang-cnt force-pushed the gke_parallelstor_switch_region_and_rename_network branch from 4349d34 to 3c54261 Compare May 16, 2025 16:48
@Shuang-cnt Shuang-cnt marked this pull request as ready for review May 16, 2025 18:32
@Shuang-cnt Shuang-cnt requested review from samskillman and a team as code owners May 16, 2025 18:32
@Shuang-cnt Shuang-cnt requested a review from cdunbar13 May 16, 2025 18:33
Copy link
Collaborator

@cdunbar13 cdunbar13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of changing the blueprint, you can update the test to use the new variables by doing something like

cli_deployment_vars:
  zone: "{{ zone }}"
  region: "{{ region }}"
  ...

The network change can be done by change vars.base_network_name the same way.

@Shuang-cnt Shuang-cnt force-pushed the gke_parallelstor_switch_region_and_rename_network branch from 3c54261 to ab1b9aa Compare May 16, 2025 19:55
… network name in the test to avoid collision with hidden resource
@Shuang-cnt Shuang-cnt force-pushed the gke_parallelstor_switch_region_and_rename_network branch from ab1b9aa to bdf7642 Compare May 16, 2025 19:58
@Shuang-cnt Shuang-cnt requested review from cdunbar13 and abbas1902 May 16, 2025 20:40
@Shuang-cnt Shuang-cnt merged commit 59468da into GoogleCloudPlatform:develop May 27, 2025
12 of 67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-chore To not include into release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants