-
Notifications
You must be signed in to change notification settings - Fork 269
Adds two new blueprints for all-in-cloud and hybrid-cloud EDA workloads #4931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds two new blueprints for all-in-cloud and hybrid-cloud EDA workloads #4931
Conversation
Summary of ChangesHello @okrause, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the available reference architectures by introducing two new blueprints tailored for Electronic Design Automation (EDA) workloads on Google Cloud. These additions provide comprehensive solutions for both fully cloud-native and hybrid cloud environments, focusing on optimizing performance and scalability for demanding EDA applications. The core of these solutions relies on Google Cloud NetApp Volumes for shared storage and the Slurm scheduler for compute management, offering flexible deployment options to meet diverse user needs. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
@bytetwin As discussed, here is the new PR with clean git history. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces two new blueprints for Electronic Design Automation (EDA) workloads, one for all-in-cloud and another for hybrid-cloud scenarios. The changes include the new blueprint YAML files, a comprehensive README for the EDA examples, and updates to existing documentation to include these new examples. The blueprints are well-structured and provide a solid starting point for users. My review includes several suggestions to improve the documentation for clarity and correctness, as well as a high-severity recommendation to refactor a complex and likely incorrect network configuration in both blueprint files to a simpler, standard, and more readable format.
663d2ad to
c2c3672
Compare
I had recommended Oliver to create a new PR because the commit history in the older one was intertwined with other commits probably due to merge instead of a rebase. @okrause this branch cannot be merged due to it not in line with develop. Please perform teh following
|
c2c3672 to
07c4fbe
Compare
be17c0b to
f9c0ba8
Compare
|
Last force push fixed a small link issue in examples/README.md. |
5f3a222 to
a4218fb
Compare
|
Rebased to latest develop. Kindly requesting approval @samskillman. |
|
/gcbrun |
ccc8341
|
@samskillman Happy new year. What is missing to merge this? |
|
/gcbrun |
Neelabh94
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution.
|
@okrause The PR-validation (required) test is failing due to missing region and zone in the blueprint. Please add the missing params, re-run the test and re-assign it to us. |
ccc8341 to
e5b711f
Compare
|
@Neelabh94 Thank you for the hint. I added regions and zones. I tested community/examples/eda/eda-all-on-cloud.yaml and it worked fine. Update: Also squashed prior commits and force pushed. |
e5b711f to
6033279
Compare
Please add your blueprint into the exclude list of unit tests here-- https://github.com/GoogleCloudPlatform/cluster-toolkit/blob/main/tools/validate_configs/validate_configs.sh#L131 |
6033279 to
36ca026
Compare
@Neelabh94 Thank you. I added the hybrid blueprint to the exclude list. Please give the automation another try. |
|
/gcbrun |
Neelabh94
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nit comments. Please address them.
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces two new blueprints for Electronic Design Automation (EDA) workloads, eda-all-on-cloud and eda-hybrid-cloud, along with comprehensive documentation. The changes are well-structured and align with the project's conventions for community examples. My review focuses on ensuring documentation accuracy and adherence to the repository's style guide. I've identified a few minor issues, such as incorrect copyright years and small inconsistencies in the documentation, and have provided suggestions for correction. The updates to the main README files to include these new examples are correctly implemented.
36ca026 to
24076fc
Compare
24076fc to
c4d8769
Compare
Neelabh94
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution.
@bytetwin can you please take a look and grant a second approval if everything is in order.
|
/gcbrun |
|
@bytetwin Can you please have a look? Thank you! |
|
Thanks @okrause for the contribution. Merged the PR. |
|
Thank you @bytetwin @Neelabh94 and @sarthakag for your help. Very appreciated. |
This PR adds two blueprints and a README.MD file to a new community/examples/eda folder. It also updates a few README files.
Both blueprints use Google Cloud NetApp Volumes as the shared NFS storage for the compute cluster.
It was developed and reviewed a #4771. This is a replacement PR for the merge.