-
Notifications
You must be signed in to change notification settings - Fork 269
Fix transient aperture device error in A3M slurm yaml #5114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix transient aperture device error in A3M slurm yaml #5114
Conversation
Summary of ChangesHello @agrawalkhushi18, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the reliability of Aperture device initialization on A3-Mega nodes by addressing transient "device not found" errors. It ensures that critical hardware components are fully operational before being accessed, preventing premature system failures and enhancing overall system stability. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request improves the reliability of Aperture device initialization on A3-Mega nodes by enabling the nvidia-fabricmanager service and implementing a polling mechanism to wait for the devices to be ready. The changes are logical and directly address the transient errors described. I've suggested one improvement for maintainability: refactoring the complex inline shell script used for polling into a separate, more readable script file within the Ansible playbook. This also addresses potential parsing issues with command substitution in YAML multiline strings, making the logic easier to understand and manage in the future.
examples/machine-learning/a3-megagpu-8g/a3mega-slurm-blueprint.yaml
Outdated
Show resolved
Hide resolved
examples/machine-learning/a3-megagpu-8g/a3mega-slurm-blueprint.yaml
Outdated
Show resolved
Hide resolved
examples/machine-learning/a3-megagpu-8g/a3mega-slurm-blueprint.yaml
Outdated
Show resolved
Hide resolved
22a079a
into
GoogleCloudPlatform:develop
This PR addresses transient "Aperture devices not found" errors on A3-Mega nodes.
The hardware that manages these devices boots at the same time as the compute node. If the node finishes booting first, it looks for the devices before they are ready, leading to a "not found" error.
A move to udev rules was made to automate mounting, but the system's "readiness check" was too rigid—it would fail instantly if the device was even a second late.
These changes improves the reliability of Aperture device initialization: