Skip to content

Conversation

@kvenkatachala333
Copy link
Member

Updated all Integration tests to use secrets and binary via zip file

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@kvenkatachala333 kvenkatachala333 added the release-chore To not include into release notes label Jan 21, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @kvenkatachala333, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the setup process for daily integration tests by transitioning from local binary compilation to a more robust and secure method of fetching pre-built binaries. By leveraging Google Cloud Storage for binary distribution and Google Secret Manager for secure access, the changes streamline test execution, reduce build times, and enhance the overall security posture of the CI/CD pipeline. This ensures that all integration tests consistently use the correct gcluster binary while protecting sensitive configuration details.

Highlights

  • Binary Acquisition Method Update: The integration tests now acquire the gcluster binary by downloading a zipped bundle from a Google Cloud Storage (GCS) path, unzipping it, and granting execution permissions, replacing the previous make command.
  • Enhanced Security with Secret Manager: The GCS path for the gcluster binary is now securely managed using Google Secret Manager, ensuring that sensitive bucket information is not hardcoded directly into the build configurations.
  • Widespread Configuration Changes: These changes have been applied consistently across all daily integration test YAML files, standardizing the binary fetching and secret handling process for all tests.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates all integration tests to fetch the gcluster binary from a GCS bucket via a zip file and utilize Google Secret Manager for the GCS path. This change enhances the reliability and security of the integration tests by ensuring a consistent binary version is used and sensitive paths are managed securely. The modifications are consistently applied across all relevant YAML files.

@sarthakag
Copy link
Contributor

Looks good. Let's run the babysit tool to run all the updated integration test.

@sarthakag sarthakag marked this pull request as ready for review January 21, 2026 08:17
@sarthakag sarthakag requested review from a team and samskillman as code owners January 21, 2026 08:17
@kvenkatachala333 kvenkatachala333 merged commit 53926f5 into GoogleCloudPlatform:develop Jan 22, 2026
58 of 73 checks passed
@kvenkatachala333 kvenkatachala333 deleted the bin_upd_all branch January 22, 2026 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-chore To not include into release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants