Skip to content

removing external validation of URLs #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shreyaprabhu-g merged 1 commit into from
Dec 4, 2025
Merged

removing external validation of URLs #181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions dagify/converter/yaml_validator/custom_validator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,18 +14,19 @@ def _is_valid(self, value):
def fail(self, value):
return f'{value} is not a valid email address.'


#K.S. edit: Removing URL validator for now to avoid broken URL links to crash the tool.
# Additionally, requiring internet access for the tool might not be a good idea.
class URLValidator(Validator):
tag = 'validURL' # This is the tag you use in your schema

def _is_valid(self, value):

try:
response = requests.get(value)
return response.status_code == 200
except requests.exceptions.RequestException as e:
print(f"Error checking URL: {e}")

#try:
# response = requests.get(value)
# return response.status_code == 200
#except requests.exceptions.RequestException as e:
# print(f"Error checking URL: {e}")
return True

# Extend default validators with your custom validators
validators = DefaultValidators.copy()
Expand Down