Skip to content

Handle async client issues #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
KonstantinMi wants to merge 4 commits into from
Closed

Handle async client issues #32

KonstantinMi wants to merge 4 commits into from

Conversation

@KonstantinMi
Copy link
Collaborator

@KonstantinMi KonstantinMi commented Sep 9, 2025

Handle async client issues:

  • set non-zero default for graceful shutdown;
  • fix logging test (make it runnable everywhere)
  • improve tests using assertThat
  • other minor changes

@KonstantinMi
Upgrade Gradle version to 8.5 (latest accepted version by Android Stu…
9afcf61 
…dio)
@KonstantinMi
Set non-zero default duration for graceful shutdown.
093c588
@KonstantinMi
In AsyncLineageProducerClientLoggingTest use mocked basic client inst…
59b8522 
…ead of real one (this is failing on environment without gcloud auth present)
@KonstantinMi
Replace
8ed8df9 
>> assertThat(testAppender.getMessagesAtLevel().stream().anyMatch($COND)).isTrue()"
with
>> assertThat(testAppender.getMessagesAtLevel()).contains("$MSG")

This provides way more explanatory error message:
>> expected to contain: projects/my-project
>> but was : [projects/test-project]
instead of
>> "expected to be true"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@midamkina midamkina Awaiting requested review from midamkina midamkina is a code owner

@ngorchakova ngorchakova Awaiting requested review from ngorchakova ngorchakova is a code owner

@gabrysiaolsz gabrysiaolsz Awaiting requested review from gabrysiaolsz gabrysiaolsz is a code owner

@chanter chanter Awaiting requested review from chanter chanter is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@KonstantinMi