-
Notifications
You must be signed in to change notification settings - Fork 7
feat: Add Lineage Enablement Cache #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
KonstantinMi
merged 12 commits into
GoogleCloudPlatform:main
from
utkarsh-goel-google:feat/lineage-enablement-cache
Dec 1, 2025
Merged
feat: Add Lineage Enablement Cache #42
KonstantinMi
merged 12 commits into
GoogleCloudPlatform:main
from
utkarsh-goel-google:feat/lineage-enablement-cache
Dec 1, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/src/main/java/com/google/cloud/datalineage/producerclient/v1/InternalClient.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/google/cloud/datalineage/producerclient/LineageEnablementCacheFactory.java
Show resolved
Hide resolved
lib/src/main/java/com/google/cloud/datalineage/producerclient/CacheOptions.java
Show resolved
Hide resolved
lib/src/main/java/com/google/cloud/datalineage/producerclient/LineageEnablementCache.java
Outdated
Show resolved
Hide resolved
.../java/com/google/cloud/datalineage/producerclient/v1/AsyncLineageProducerClientSettings.java
Show resolved
Hide resolved
lib/src/main/java/com/google/cloud/datalineage/producerclient/v1/InternalClient.java
Outdated
Show resolved
Hide resolved
...n/java/com/google/cloud/datalineage/producerclient/v1/SyncLineageProducerClientSettings.java
Show resolved
Hide resolved
lib/src/test/java/com/google/cloud/datalineage/producerclient/ProjectStatusCacheTest.java
Outdated
Show resolved
Hide resolved
lib/src/test/java/com/google/cloud/datalineage/producerclient/v1/LineageBaseSettingsTest.java
Show resolved
Hide resolved
gabrysiaolsz
approved these changes
Nov 4, 2025
KonstantinMi
approved these changes
Nov 14, 2025
Collaborator
KonstantinMi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
...src/main/java/com/google/cloud/datalineage/producerclient/LineageEnablementCacheFactory.java
Show resolved
Hide resolved
lib/src/main/java/com/google/cloud/datalineage/producerclient/LineageEnablementCache.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/google/cloud/datalineage/producerclient/LineageEnablementCacheSettings.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/google/cloud/datalineage/producerclient/StandardLineageEnablementCache.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/google/cloud/datalineage/producerclient/StandardLineageEnablementCache.java
Outdated
Show resolved
Hide resolved
chanter
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces a new caching mechanism for Lineage Enablement and significantly refactors the existing cache implementation to
improve maintainability and reduce code duplication.
Key Changes:
New Lineage Enablement Cache:
PERMISSION_DENIEDerrors withLINEAGE_INGESTION_DISABLEDreason that occur when Lineage is not enabled for a project and client.unnecessary network traffic.
Refactoring to a Generic Cache Model:
ProjectStatusCacheclass has been created to handle the core caching logic using a composition-based design.StandardApiEnablementCacheandStandardLineageEnablementCache) now act as simple, lightweightwrappers around this generic component.
Consolidated Cache Configuration:
ApiEnablementCacheOptions,ApiEnablementCacheSettings) have beenremoved and replaced with two generic classes:
CacheOptionsandCacheSettings.