Open
Conversation
…c-templates into support_multiple_tables
surjits254
requested changes
Apr 2, 2025
Comment on lines
+190
to
+191
| source_tables_list = input_jdbc_table.split(";") | ||
| target_tables_list = big_query_table.split(";") |
Collaborator
There was a problem hiding this comment.
instead of list can we accept dictionary for source:target.
Keep these 2 variables same to avoid breaking change but add another variable which accepts a key:value of source:target mapping so users do not have to worry about order
Collaborator
Author
There was a problem hiding this comment.
Actually @surjits254 if we would do that, then we need to change our older pattern of accepting the input parameters. Below mentioned are the two older parameters :-
--jdbc.bigquery.input.table='test.demo'
--jdbc.bigquery.output.table='jdbctobq'
Thus, without changing any of the older support we need to come up with some solution. Hence, figured out this way. Do you think so we should change the older format to dictionary ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.