Skip to content

Feat: Added secret manager for JDBC url#1072

Open
uriarriaga wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
uriarriaga:main
Open

Feat: Added secret manager for JDBC url#1072
uriarriaga wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
uriarriaga:main

Conversation

@uriarriaga
Copy link

No description provided.

@shashank-google shashank-google changed the title Added secret manager for JDBC url Feat: Added secret manager for JDBC url Aug 22, 2025
@surjits254
Copy link
Collaborator

surjits254 commented Aug 25, 2025

Discussed with @uriarriaga to create PR from dataproc-templates branch instead of forked branch. As integration test runs are not supported from forked branch.
cc: @sundar-mudupalli-work

@sundar-mudupalli-work
Copy link
Collaborator

Uriel,

Thank you so much for your contribution. Can you take a look how the jdbc-to-jdbc templates handle secrets ?

The documentation is here

The specific code fragment where the secret is fetched is here

In general, I would like the parameter and behavior to be consistent across the different templates, so that they are easier to use. If you think we should use the behavior per your code, can you explain ?

Thanks again.

Sundar Mudupalli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments