Feat: Added secret manager for JDBC url#1072
Open
uriarriaga wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
Open
Feat: Added secret manager for JDBC url#1072uriarriaga wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
uriarriaga wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
Conversation
Collaborator
|
Discussed with @uriarriaga to create PR from dataproc-templates branch instead of forked branch. As integration test runs are not supported from forked branch. |
Collaborator
|
Uriel, Thank you so much for your contribution. Can you take a look how the The documentation is here The specific code fragment where the secret is fetched is here In general, I would like the parameter and behavior to be consistent across the different templates, so that they are easier to use. If you think we should use the behavior per your code, can you explain ? Thanks again. Sundar Mudupalli |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.