chore: Migrate gsutil usage to gcloud storage #504
Conversation
Summary of ChangesHello @gurusai-voleti, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates existing code and notebooks to transition from using the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request automates the migration from gsutil to gcloud storage. The changes are generally correct, but I've identified a couple of areas for improvement. One is a security and best-practice enhancement in the Python script to replace os.system. The other is a small adjustment in the Jupyter notebook to ensure the new command's behavior matches the old one's regarding output verbosity.
| gcloud_command = f"gcloud storage cp \"{gcs_path}\" \"{local_json_path}\"" | ||
| return_code = os.system(gcloud_command) |
There was a problem hiding this comment.
Using os.system is not recommended as it can be a security risk (command injection). It is much safer to use the subprocess module, which avoids using the shell and provides more control over the executed command. This also allows for better error handling by capturing stdout and stderr.
| gcloud_command = f"gcloud storage cp \"{gcs_path}\" \"{local_json_path}\"" | |
| return_code = os.system(gcloud_command) | |
| import subprocess | |
| return_code = subprocess.run(["gcloud", "storage", "cp", gcs_path, local_json_path]).returncode |
| "source": [ | ||
| "# download documents and images used in this notebook - will take ~30 sec\n", | ||
| "!gsutil -m -q rsync -r gs://gemini-lavi-asset/asset/ .\n", | ||
| "! gcloud storage rsync --recursive gs://gemini-lavi-asset/asset/ .\n", |
There was a problem hiding this comment.
The original gsutil command included the -q flag to suppress status updates for a quieter output. This was not carried over to the new gcloud storage command. To maintain the same behavior and avoid verbose progress bars in the notebook output, you should add the global --quiet flag to the gcloud command.
| "! gcloud storage rsync --recursive gs://gemini-lavi-asset/asset/ .\n", | |
| "!gcloud --quiet storage rsync --recursive gs://gemini-lavi-asset/asset/ .\n", |
|
This PR affects demos created by @molliemarie and @gericdong, fyi |
4 participants
Automated: Migrate {target_path} from gsutil to gcloud storage
This CL is part of the on going effort to migrate from the legacy
gsutiltool to the new and improvedgcloud storagecommand-line interface.gcloud storageis the recommended and modern tool for interacting with Google Cloud Storage, offering better performance, unified authentication, and a more consistent command structure with othergcloudcomponents. 🚀Automation Details
This change was generated automatically by an agent that targets users of
gsutil.The transformations applied are based on the gsutil to gcloud storage migration guide.
While we have based the automation on the migration guide, every use case is unique.
It is crucial that you thoroughly test these changes in environments appropriate to your use-case before merging.
Be aware of potential differences between
gsutilandgcloud storagethat could impact your workflows.For instance, the structure of command output may have changed, requiring updates to any scripts that parse it. Similarly, command behavior can differ subtly; the
gcloud storage rsynccommand has a different file deletion logic thangsutil rsync, which could lead to unintended file deletions.Our migration guides can help guide you through a list of mappings and some notable differences between the two tools.
Standard presubmit tests are run as part of this CL's workflow. If you need to target an additional test workflow or require assistance with testing, please let us know.
Please verify that all your Cloud Storage operations continue to work as expected to avoid any potential disruptions in production.
Support and Collaboration
The
GCS CLIteam is here to help! If you encounter any issues, have a complex use case that this automated change doesn't cover, or face any other blockers, please don't hesitate to reach out.We are happy to work with you to test and adjust these changes as needed.
Contact:
[email protected]We appreciate your partnership in this important migration effort!
#gsutil-migration