-
Notifications
You must be signed in to change notification settings - Fork 49
Changes to make queryPath optional #162
base: master
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #162 +/- ##
============================================
- Coverage 12.45% 12.43% -0.03%
Complexity 63 63
============================================
Files 53 53
Lines 2480 2484 +4
Branches 207 208 +1
============================================
Hits 309 309
- Misses 2152 2156 +4
Partials 19 19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| .usingStandardSql() | ||
| .withMethod(Method.DEFAULT)) | ||
| .apply("AddTableNameAsKey", WithKeys.of(tableRef())); | ||
| throw new IllegalArgumentException("Export method not supported"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May not be the intended behaviour but since the EXPORT case used to work with DEFAULT read earlier, are we declaring that somewhere before removing the support altogether?
src/main/java/com/google/swarm/tokenization/common/BigQueryReadTransform.java
Show resolved
Hide resolved
| .apply("AddTableNameAsKey", WithKeys.of(tableRef())); | ||
| } | ||
|
|
||
| case EXPORT: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just club EXPORT and DIRECT_READ together and throw the exception "Only DEFAULT Read Method supported"?
case EXPORT: case DIRECT_READ: throw new IllegalArgumentException("Only DEFAULT READ method supported");
Summary (Short summary of what is being done) :
Simplify REID workflow by making the query parameter optionalDescription (Describe in detail the fix made) :
The REID workflow required users to compulsarily provide SQL query to read from the BigQuery. This involved manual steps to create a GCS object containing sql query and passing its path in the pipeline parameter. With this change, the queryPath parameter has been made optional and users can run REID pipeline without needing to provide a SQL query.Bug ID (if any) :
b/293427326Public Documentation (if any) :
TESTED (Test Cases with scenario and description - must have 1 positive and 1 negative scenario) :