-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat(genai): add tool samples (2) #3281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(genai): add tool samples (2) #3281
Conversation
|
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
Summary of ChangesHello @jdomingr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the GenAI SDK samples by introducing new examples for advanced tool usage. It provides a multimodal sample demonstrating content generation with the CodeExecution tool using both text and a local image, and another sample illustrating how to leverage the VertexAISearch tool with text input to retrieve information from a datastore. These additions expand the practical demonstrations of the SDK's capabilities. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds two new GenAI tool samples: one for code execution with an image, and another for Vertex AI search. The changes are well-structured. I've provided a few suggestions to improve the correctness and robustness of the new samples. Specifically, I've pointed out an issue with how the executable code is extracted, how the datastore is configured in the Vertex AI search sample, and a potential null reference issue when parsing the response. Addressing these points will make the samples more reliable and easier for developers to use.
Add new tool samples
Note: I have not created a test for the ToolsVertexAISearchWithTxt.cs sample because it requires a datastore, but locally I tested it and it's working correctly.