-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat(genai): add tool samples (3) #3283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(genai): add tool samples (3) #3283
Conversation
|
Here is the summary of changes. You are about to add 3 region tags.
This comment is generated by snippet-bot.
|
Summary of ChangesHello @jdomingr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the GenAI SDK's sample suite by integrating new examples for powerful generative AI tools. These additions provide developers with practical demonstrations of how to leverage Enterprise Web Search, Google Maps, and a combination of Google Search and URL Context within their applications, enhancing the SDK's utility and ease of adoption for advanced content generation scenarios. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds three new samples demonstrating how to use different tools with the GenAI API: Enterprise Web Search, Google Maps, and a combination of Google Search and URL Context. The code is well-structured and the new samples are a valuable addition.
I've made a few suggestions to improve robustness and code style:
- In all three sample files, I've pointed out an unsafe access to the response content which could lead to runtime exceptions. I've suggested a safer way to extract the text.
- In the
ToolsGoogleSearchAndUrlContextWithTxtsample, I've suggested a minor simplification for string construction to improve readability.
Add new tool samples:
All local tests have passed