-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat(genai): add text generation samples (5) #3285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(genai): add text generation samples (5) #3285
Conversation
|
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
Summary of ChangesHello @jdomingr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the GenAI samples by introducing two new text generation functionalities that leverage video input. One sample processes videos from Google Cloud Storage to provide summaries and chapter breakdowns, while the other generates a blog post from a YouTube video, expanding the capabilities of the GenAI SDK for multimodal content analysis. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds two new text generation samples demonstrating how to use videos from Google Cloud Storage and YouTube as input. The implementation is straightforward and the accompanying tests are adequate for these examples. My main feedback is to improve the robustness of the response handling. Currently, the code is susceptible to an IndexOutOfRangeException if the API returns no candidates. I've suggested using the idiomatic GetText() extension method provided by the library to safely handle the response, making the samples more resilient.
Add new text generation samples:
All local tests have passed