feat(reporting): align delegated reporter protocol with ReportingContext and multi-type dispatch - #591
Open
saurabh-net wants to merge 2 commits into
Open
feat(reporting): align delegated reporter protocol with ReportingContext and multi-type dispatch#591saurabh-net wants to merge 2 commits into
saurabh-net wants to merge 2 commits into
Conversation
…ext and multi-type dispatch
saurabh-net
requested review from
IsmailMehdi,
helloeve and
prernakakkar-google
as code owners
September 4, 2026 12:56
prernakakkar-google
approved these changes
Sep 7, 2026
Collaborator
|
/gcbrun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context & Problem
This PR aligns the delegated remote reporting mechanism (
RemoteReporter) with the same structured context model established for delegated scorers:Structured
ReportingContextin Protobuf:Previously,
ReportingRequestonly containedReporterSpec(name, configuration JSON, timeout), omitting evaluation context (job_id,run_time,store_type, DataFrame records, and database). We introduceReportingContextineval_agent.proto:Multi-Type Dispatch (Option 2):
Native EvalBench reporters (
Reporter.store) are invoked across four distinct store phases:STORETYPE.CONFIGS,STORETYPE.EVALS,STORETYPE.SCORES, andSTORETYPE.SUMMARY. Previously,RemoteReporterhad hardcoded filtering (if type_name != "EVALS": return), which prevented remote reporters (like CSV or custom sinks) from receiving and persisting other report tables. We now dispatch everystore_typeacross the stream along with its serialized DataFrame rows, allowing the remote worker to decide which types to process.Logging & Diagnostics:
[REMOTE_REPORTER]prefixes for easy debugging across stream sessions.Changes
evalbench/evalproto/eval_agent.proto: AddedReportingContextmessage and updatedReportingRequestto include context.evalbench/reporting/remote_reporter.py: ConstructedReportingContext, serialized DataFrame records with ISO date formatting, dispatched across allstore_typecalls, and handled response logging.evalbench/test/agent_grpc_proxy_test.py: Added comprehensive unit tests coveringReportingContextfield validation, multi-type dispatch across all 4 store phases (CONFIGS,EVALS,SCORES,SUMMARY), timeout handling, and failure response handling.Verification
pytest evalbench/test/agent_grpc_proxy_test.py evalbench/test/agent_grpc_proxy_integration_test.py(9 passed, 0 warnings).pycodestyleclean (0 errors).main.